You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/07 20:24:21 UTC

[GitHub] [cloudstack] stephankruggg opened a new pull request, #6957: Allow VPC offering creation only with active VR service offerings

stephankruggg opened a new pull request, #6957:
URL: https://github.com/apache/cloudstack/pull/6957

   ### Description
   
   During the creation of a VPC offering, any type of service offering can be informed. However, selecting an improper service offering type can lead to a VR boot failure. Furthermore, during VPC or network offering creation, it is possible to provide an inactive service offering. 
   
   This PR allows the creation of VPC offerings only with VR service offerings, and blocks the creation of new VPC and network offerings with inactive service offerings. Any offering already created will maintain current behavior. 
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### How Has This Been Tested?
   
   I applied the changes in a local lab and attempted to create network offerings and VPC offerings with inactive service offerings. Additionally, I attempted to create VPC offerings with offerings in which the System VM type is not `domainrouter`. All attempts failed.
   
   Attempts where the System VM type is `domainrouter` and the offering is active were successful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.

blueorangutan commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1404057251

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5408


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1375805297

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.

weizhouapache commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1409216458

   > @weizhouapache I manually tested, working as expected.
   > 
   > Different type of offering:
   > 
   > ```
   > (lab) 🐱 > create vpcoffering displaytext=test name=test supportedservices=dhcp serviceofferingid=373b6dc8-ee89-4fe9-a35b-6fd8e1282ed5
   > 🙈 Error: (HTTP 431, error code 4350) The specified service offering [Service offering {"id":19,"name":"offering-test","uuid":"373b6dc8-ee89-4fe9-a35b-6fd8e1282ed5"}.] is of type [consoleproxy]. Virtual routers can only be created with service offering of type [domainrouter].
   > ```
   > 
   > Inactive offering:
   > 
   > ```
   > (lab) 🐱 > create vpcoffering displaytext=teste name=teste supportedservices=dhcp serviceofferingid=b0e0c84b-4dc1-4c0b-bf76-04553d04755f
   > 🙈 Error: (HTTP 431, error code 4350) The specified service offering [Service offering {"id":18,"name":"removida","uuid":"b0e0c84b-4dc1-4c0b-bf76-04553d04755f"}.] is inactive.
   > ```
   
   @BryanMLima  cool, thanks.
   
   @DaanHoogland I think this is ready for merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.

weizhouapache commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1404042944

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.

blueorangutan commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1407068554

   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by GitBox <gi...@apache.org>.

weizhouapache commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1368050980

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.

blueorangutan commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1404044008

   @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.

weizhouapache commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1406927862

   @JoaoJandre @BryanMLima 
   I notice you have approved it. Does the code look good to you, or have you manually tested it ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.

weizhouapache commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1407067470

   @blueorangutan tesy


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by GitBox <gi...@apache.org>.

DaanHoogland commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1375804626

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by sonarcloud.

sonarcloud[bot] commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1406664341

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6957)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6957&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6957&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6957&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6957&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6957&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6957&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6957&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6957&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6957&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6957&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6957&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6957&resolved=false&types=CODE_SMELL)
   
   [![58.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/50-16px.png '58.2%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6957&metric=new_coverage&view=list) [58.2% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6957&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6957&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6957&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] github-actions[bot] commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1370634324

   This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1375836962

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5210


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] BryanMLima commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "BryanMLima (via GitHub)" <gi...@apache.org>.

BryanMLima commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1409166936

   I manually tested, working as expected.
   
   Different type of offering:
   ~~~
   (lab) 🐱 > create vpcoffering displaytext=test name=test supportedservices=dhcp serviceofferingid=373b6dc8-ee89-4fe9-a35b-6fd8e1282ed5
   🙈 Error: (HTTP 431, error code 4350) The specified service offering [Service offering {"id":19,"name":"offering-test","uuid":"373b6dc8-ee89-4fe9-a35b-6fd8e1282ed5"}.] is of type [consoleproxy]. Virtual routers can only be created with service offering of type [domainrouter].
   ~~~
   
   Inactive offering:
   ~~~
   (lab) 🐱 > create vpcoffering displaytext=teste name=teste supportedservices=dhcp serviceofferingid=b0e0c84b-4dc1-4c0b-bf76-04553d04755f
   🙈 Error: (HTTP 431, error code 4350) The specified service offering [Service offering {"id":18,"name":"removida","uuid":"b0e0c84b-4dc1-4c0b-bf76-04553d04755f"}.] is inactive.
   ~~~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] JoaoJandre commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.

JoaoJandre commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1409219069

   @weizhouapache I did not manually test it as far as I remember (this was more then one month ago). But I re-reviewed the changes and the code looks good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.

DaanHoogland commented on code in PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#discussion_r1159823690


##########
server/src/test/java/com/cloud/network/NetworkServiceImplTest.java:
##########
@@ -713,4 +724,50 @@ public void testCheckAndUpdateNetworkResetSuccess() {
         Assert.assertNull(networkVO.getIp6Dns1());
         Assert.assertNull(networkVO.getIp6Dns2());
     }
+    @Test
+    public void validateIfServiceOfferingIsActiveAndSystemVmTypeIsDomainRouterTestMustThrowInvalidParameterValueExceptionWhenServiceOfferingIsNull() {
+        doReturn(null).when(serviceOfferingDaoMock).findById(anyLong());
+
+        String expectedMessage = String.format("Could not find specified service offering [%s].", 1l);
+        InvalidParameterValueException assertThrows = Assert.assertThrows(expectedException, () -> {
+            service.validateIfServiceOfferingIsActiveAndSystemVmTypeIsDomainRouter(1l);
+        });
+
+        Assert.assertEquals(expectedMessage, assertThrows.getMessage());
+    }
+
+    @Test
+    public void validateIfServiceOfferingIsActiveAndSystemVmTypeIsDomainRouterTestMustThrowInvalidParameterValueExceptionWhenServiceOfferingStateIsInactive() {
+        doReturn(serviceOfferingVoMock).when(serviceOfferingDaoMock).findById(anyLong());
+        doReturn(ServiceOffering.State.Inactive).when(serviceOfferingVoMock).getState();
+
+        String expectedMessage = String.format("The specified service offering [%s] is inactive.", serviceOfferingVoMock);
+        InvalidParameterValueException assertThrows = Assert.assertThrows(expectedException, () -> {
+            service.validateIfServiceOfferingIsActiveAndSystemVmTypeIsDomainRouter(1l);
+        });
+
+        Assert.assertEquals(expectedMessage, assertThrows.getMessage());
+    }
+
+    @Test
+    public void validateIfServiceOfferingIsActiveAndSystemVmTypeIsDomainRouterTestMustThrowInvalidParameterValueExceptionWhenSystemVmTypeIsNotDomainRouter() {
+        doReturn(serviceOfferingVoMock).when(serviceOfferingDaoMock).findById(anyLong());
+        doReturn(ServiceOffering.State.Active).when(serviceOfferingVoMock).getState();
+        doReturn(VirtualMachine.Type.ElasticLoadBalancerVm.toString()).when(serviceOfferingVoMock).getSystemVmType();
+
+        String expectedMessage = String.format("The specified service offering [%s] is of type [%s]. Virtual routers can only be created with service offering of type [%s].",
+                serviceOfferingVoMock, serviceOfferingVoMock.getSystemVmType(), VirtualMachine.Type.DomainRouter.toString().toLowerCase());
+        InvalidParameterValueException assertThrows = Assert.assertThrows(expectedException, () -> {
+            service.validateIfServiceOfferingIsActiveAndSystemVmTypeIsDomainRouter(1l);
+        });
+
+        Assert.assertEquals(expectedMessage, assertThrows.getMessage());
+    }
+
+    @Test
+    public void validateIfServiceOfferingIsActiveAndSystemVmTypeIsDomainRouterTestMustNotThrowInvalidParameterValueExceptionWhenSystemVmTypeIsDomainRouter() {
+        NetworkServiceImpl networkServiceImplMock = mock(NetworkServiceImpl.class);
+
+        networkServiceImplMock.validateIfServiceOfferingIsActiveAndSystemVmTypeIsDomainRouter(1l);

Review Comment:
   a bit after the fact, but what is the intention of this test @stephankruggg ? It seems to test if a mock is callable/being called...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.

blueorangutan commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1406978130

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5423


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] codecov[bot] commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by codecov.

codecov[bot] commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1406660669

   # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#6957](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c20b5ac) into [main](https://codecov.io/gh/apache/cloudstack/commit/c2b75f4c81cf0b2846da10de52b9dd66292bff36?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c2b75f4) will **increase** coverage by `0.20%`.
   > The diff coverage is `40.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #6957      +/-   ##
   ============================================
   + Coverage     11.58%   11.79%   +0.20%     
   - Complexity     7550     7679     +129     
   ============================================
     Files          2494     2505      +11     
     Lines        247073   246348     -725     
     Branches      38614    38429     -185     
   ============================================
   + Hits          28633    29049     +416     
   + Misses       214695   213517    -1178     
   - Partials       3745     3782      +37     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../cloud/configuration/ConfigurationManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbmZpZ3VyYXRpb24vQ29uZmlndXJhdGlvbk1hbmFnZXJJbXBsLmphdmE=) | `12.53% <0.00%> (+0.04%)` | :arrow_up: |
   | [...ain/java/com/cloud/network/NetworkServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL25ldHdvcmsvTmV0d29ya1NlcnZpY2VJbXBsLmphdmE=) | `11.40% <41.66%> (+0.23%)` | :arrow_up: |
   | [...ain/java/com/cloud/network/vpc/VpcManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL25ldHdvcmsvdnBjL1ZwY01hbmFnZXJJbXBsLmphdmE=) | `8.67% <50.00%> (+0.03%)` | :arrow_up: |
   | [...er/src/main/java/com/cloud/hypervisor/KVMGuru.java](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2h5cGVydmlzb3IvS1ZNR3VydS5qYXZh) | `50.81% <0.00%> (-22.41%)` | :arrow_down: |
   | [...com/cloud/agent/manager/ConnectedAgentAttache.java](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvYWdlbnQvbWFuYWdlci9Db25uZWN0ZWRBZ2VudEF0dGFjaGUuamF2YQ==) | `25.00% <0.00%> (-12.50%)` | :arrow_down: |
   | [...m/resource/wrapper/LibvirtReadyCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UmVhZHlDb21tYW5kV3JhcHBlci5qYXZh) | `61.53% <0.00%> (-11.19%)` | :arrow_down: |
   | [...ubernetes/cluster/utils/KubernetesClusterUtil.java](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9pbnRlZ3JhdGlvbnMva3ViZXJuZXRlcy1zZXJ2aWNlL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2t1YmVybmV0ZXMvY2x1c3Rlci91dGlscy9LdWJlcm5ldGVzQ2x1c3RlclV0aWwuamF2YQ==) | `2.28% <0.00%> (-8.18%)` | :arrow_down: |
   | [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `21.15% <0.00%> (-7.70%)` | :arrow_down: |
   | [...rg/apache/cloudstack/quota/QuotaStatementImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL1F1b3RhU3RhdGVtZW50SW1wbC5qYXZh) | `36.28% <0.00%> (-3.99%)` | :arrow_down: |
   | [.../main/java/com/cloud/domain/dao/DomainDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9kb21haW4vZGFvL0RvbWFpbkRhb0ltcGwuamF2YQ==) | `19.49% <0.00%> (-1.89%)` | :arrow_down: |
   | ... and [86 more](https://codecov.io/gh/apache/cloudstack/pull/6957?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.

weizhouapache commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1406925717

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by GitBox <gi...@apache.org>.

weizhouapache commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1372002749

   @stephankruggg 
   can you please fix the conflicts ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache closed pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by GitBox <gi...@apache.org>.

weizhouapache closed pull request #6957: Allow VPC offering creation only with active VR service offerings 
URL: https://github.com/apache/cloudstack/pull/6957


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.

blueorangutan commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1407339131

   <b>Trillian test result (tid-6017)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40304 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6957-t6017-kvm-centos7.zip
   Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.

DaanHoogland commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1409904379

   Thanks @JoaoJandre @BryanMLima , this is exactly what we want :+1:  : minimal one tester and one code reviewer. Thanks for confirming.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland merged pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.

DaanHoogland merged PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] BryanMLima commented on a diff in pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by GitBox <gi...@apache.org>.

BryanMLima commented on code in PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#discussion_r1059479671


##########
api/src/main/java/com/cloud/network/NetworkService.java:
##########
@@ -34,12 +34,12 @@
 import org.apache.cloudstack.api.command.user.network.UpdateNetworkCmd;
 import org.apache.cloudstack.api.command.user.vm.ListNicsCmd;
 import org.apache.cloudstack.api.response.AcquirePodIpCmdResponse;

Review Comment:
   ```suggestion
   import org.apache.cloudstack.api.response.AcquirePodIpCmdResponse;
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1368051317

   @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by GitBox <gi...@apache.org>.

blueorangutan commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1368055503

   Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5144


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.

weizhouapache commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1407067633

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #6957: Allow VPC offering creation only with active VR service offerings

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.

blueorangutan commented on PR #6957:
URL: https://github.com/apache/cloudstack/pull/6957#issuecomment-1406926289

   @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org