[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24472: [SPARK-27578][SQL]Add support for "interval '23:59:59' hour to second"

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24472: [SPARK-27578][SQL]Add support for "interval '23:59:59' hour to second"
URL: https://github.com/apache/spark/pull/24472#discussion_r287579637
 
 

 ##########
 File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
 ##########
 @@ -56,6 +56,9 @@ private static String unitRegex(String unit) {
   private static Pattern dayTimePattern =
     Pattern.compile("^(?:['|\"])?([+|-])?(\\d+) (\\d+):(\\d+):(\\d+)(\\.(\\d+))?(?:['|\"])?$");
 
+  private static final Pattern hourTimePattern =
+          Pattern.compile("^(?:['|\"])?(\\d+):(\\d+):(\\d+)(\\.(\\d+))?(?:['|\"])?$");
 
 Review comment:
   indentation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org