[jira] [Commented] (FLINK-4517) scala code refactoring

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15441203#comment-15441203 ] 

ASF GitHub Bot commented on FLINK-4517:
---------------------------------------

GitHub user shijinkui opened a pull request:

    https://github.com/apache/flink/pull/2428

    [FLINK-4517] scala code refactoring

    the refacter type:
    
    1. case class does't need `new`
    2. case block does't need `{  ...  }`
    3. match-case instead of isInstanceOf 
    
    references the related [FLINK-4517]
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shijinkui/flink scala-refactoring

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2428
    
----
commit b02bef1f23943b08908f408e03f75fb8c5220a28
Author: shijinkui <sh...@huawei.com>
Date:   2016-08-27T09:17:04Z

    [FLINK-4517] scala code refactoring

----


> scala code refactoring
> ----------------------
>
>                 Key: FLINK-4517
>                 URL: https://issues.apache.org/jira/browse/FLINK-4517
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: shijinkui
>            Priority: Minor
>
> such as:
> 1. case class does't need `new`
> 2. case block does't need `{  ...  }`
> 3. match-case instead of isInstanceOf 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)