[GitHub] [cordova-android] janpio commented on a change in pull request #764: feat: Build app bundles (.aab files)

[GitBox <gi...@apache.org>]

janpio commented on a change in pull request #764: feat: Build app bundles (.aab files)
URL: https://github.com/apache/cordova-android/pull/764#discussion_r304276807
 
 

 ##########
 File path: bin/templates/cordova/lib/build.js
 ##########
 @@ -105,11 +107,36 @@ function parseOpts (options, resolvedTarget, projectRoot) {
     }
 
     if (!ret.packageInfo) {
-        if (Object.keys(packageArgs).length > 0) {
+        // The following loop is to decide whether to print a warning about generating a signed archive
+        // We only want to produce a warning if they are using a config property that is related to signing, but
+        // missing the required properties for signing. We don't want to produce a warning if they are simply
+        // using a build property that isn't related to singing, such as --packageType
+        let shouldWarn = false;
+        const signingKeys = ['keystore', 'alias', 'storePassword', 'password', 'keystoreType'];
+        for (let key in packageArgs) {
 
 Review comment:
   I think the current code is perfectly fine and simple to understand.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org