You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <be...@qqmail.nl> on 2015/11/26 11:30:21 UTC

RE: svn commit: r1716593 - in /subversion/trunk/subversion: mod_dav_svn/repos.c tests/cmdline/lock_tests.py tests/cmdline/mod_dav_svn_tests.py tests/cmdline/svntest/main.py


> -----Original Message-----
> From: kotkov@apache.org [mailto:kotkov@apache.org]
> Sent: donderdag 26 november 2015 11:18
> To: commits@subversion.apache.org
> Subject: svn commit: r1716593 - in /subversion/trunk/subversion:
> mod_dav_svn/repos.c tests/cmdline/lock_tests.py
> tests/cmdline/mod_dav_svn_tests.py tests/cmdline/svntest/main.py
> 
> Author: kotkov
> Date: Thu Nov 26 10:18:01 2015
> New Revision: 1716593
> 
> URL: http://svn.apache.org/viewvc?rev=1716593&view=rev
> Log:
> Fixup the recent solution for issue SVN-4514 by discouraging caching for
> requests that specify ?r=WORKINGREV in the url, e.g.
> 
>   https://svn.apache.org/repos/asf/subversion/trunk/README?r=1716593

I think you should document this as not sending ?p=<> in the url.

Once you add a ?p=, an additional &r= specifying the same or lower revision is 100% safe.

	Bert

Re: svn commit: r1716593 - in /subversion/trunk/subversion: mod_dav_svn/repos.c tests/cmdline/lock_tests.py tests/cmdline/mod_dav_svn_tests.py tests/cmdline/svntest/main.py

Posted by Evgeny Kotkov <ev...@visualsvn.com>.
Bert Huijben <be...@qqmail.nl> writes:

>> Fixup the recent solution for issue SVN-4514 by discouraging caching for
>> requests that specify ?r=WORKINGREV in the url, e.g.
>>
>>   https://svn.apache.org/repos/asf/subversion/trunk/README?r=1716593
>
> I think you should document this as not sending ?p=<> in the url.
>
> Once you add a ?p=, an additional &r= specifying the same or lower revision
> is 100% safe.

Thanks for taking a look at this change.

I updated the log message for this revision in order to make more precise.


Regards,
Evgeny Kotkov

Re: svn commit: r1716593 - in /subversion/trunk/subversion: mod_dav_svn/repos.c tests/cmdline/lock_tests.py tests/cmdline/mod_dav_svn_tests.py tests/cmdline/svntest/main.py

Posted by Evgeny Kotkov <ev...@visualsvn.com>.
Bert Huijben <be...@qqmail.nl> writes:

>> Fixup the recent solution for issue SVN-4514 by discouraging caching for
>> requests that specify ?r=WORKINGREV in the url, e.g.
>>
>>   https://svn.apache.org/repos/asf/subversion/trunk/README?r=1716593
>
> I think you should document this as not sending ?p=<> in the url.
>
> Once you add a ?p=, an additional &r= specifying the same or lower revision
> is 100% safe.

Thanks for taking a look at this change.

I updated the log message for this revision in order to make more precise.


Regards,
Evgeny Kotkov