You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/06/10 19:35:49 UTC

Review Request 22422: Switched to subprocess.Popen to get stdout streamed from verify-reviews.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22422/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-1469
    https://issues.apache.org/jira/browse/MESOS-1469


Repository: mesos-git


Description
-------

using Popen instead of check_output means that the output is streamed to the console. As such, runs that timeout will still include partial logs enabling us to debug any issues. 


Diffs
-----

  support/verify-reviews.py a84f9ce6d2c4b40edf0539ec3b7cefadc3c29ba3 

Diff: https://reviews.apache.org/r/22422/diff/


Testing
-------

run locally under python 2.7 and 2.6


Thanks,

Dominic Hamon

Re: Review Request 22422: Switched to subprocess.Popen to get stdout streamed from verify-reviews.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22422/#review45259
-----------------------------------------------------------



support/verify-reviews.py
<https://reviews.apache.org/r/22422/#comment79993>

    You want this:
    
        proc = subprocess.Popen(command, stderr=subprocess.STDOUT, shell=True)
        (out, err) = proc.communicate()
        if proc.returncode !=0 :
          raise subprocess.CalledProcessError(proc.returncode, command, out)
    


- Vinod Kone


On June 10, 2014, 5:35 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22422/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 5:35 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1469
>     https://issues.apache.org/jira/browse/MESOS-1469
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> using Popen instead of check_output means that the output is streamed to the console. As such, runs that timeout will still include partial logs enabling us to debug any issues. 
> 
> 
> Diffs
> -----
> 
>   support/verify-reviews.py a84f9ce6d2c4b40edf0539ec3b7cefadc3c29ba3 
> 
> Diff: https://reviews.apache.org/r/22422/diff/
> 
> 
> Testing
> -------
> 
> run locally under python 2.7 and 2.6
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 22422: Switched to subprocess.Popen to get stdout streamed from verify-reviews.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22422/#review45276
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On June 10, 2014, 6:50 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22422/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 6:50 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1469
>     https://issues.apache.org/jira/browse/MESOS-1469
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> using Popen instead of check_output means that the output is streamed to the console. As such, runs that timeout will still include partial logs enabling us to debug any issues. 
> 
> 
> Diffs
> -----
> 
>   support/verify-reviews.py a84f9ce6d2c4b40edf0539ec3b7cefadc3c29ba3 
> 
> Diff: https://reviews.apache.org/r/22422/diff/
> 
> 
> Testing
> -------
> 
> run locally under python 2.7 and 2.6
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 22422: Switched to subprocess.Popen to get stdout streamed from verify-reviews.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22422/
-----------------------------------------------------------

(Updated June 10, 2014, 11:50 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-1469
    https://issues.apache.org/jira/browse/MESOS-1469


Repository: mesos-git


Description
-------

using Popen instead of check_output means that the output is streamed to the console. As such, runs that timeout will still include partial logs enabling us to debug any issues. 


Diffs (updated)
-----

  support/verify-reviews.py a84f9ce6d2c4b40edf0539ec3b7cefadc3c29ba3 

Diff: https://reviews.apache.org/r/22422/diff/


Testing
-------

run locally under python 2.7 and 2.6


Thanks,

Dominic Hamon