You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/09/16 13:35:33 UTC
[PR] Fix stale Javadoc and GAV typo in external-profile tests (follow-up to #13141) [maven]
gnodet opened a new pull request, #13156:
URL: https://github.com/apache/maven/pull/13156
Follow-up to #13141, fixing three issues found during review of #13155.
- `DefaultModelBuilderTest`: update `resolvedProfilesRequest()` Javadoc — the sentence *"their profiles contribute no repositories"* is now false for JDK/OS/`activeByDefault`-activated profiles; fix `active-by-default-profile` `resolvedSource` GAV typo (`org.apache.maven.test`, matching the fixture and existing test convention)
- `active-by-default-profile.xml`: fix `groupId` plural → singular (`org.apache.maven.test`) to match the rest of the `poms/factory/` fixtures and the test coordinate hint
- `ExternalModelProfileActivationTest` (compat): update class-level Javadoc — same stale sentence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix stale Javadoc and GAV typo in external-profile tests (follow-up to #13141) [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #13156:
URL: https://github.com/apache/maven/pull/13156#discussion_r4037963662
##########
impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelBuilderTest.java:
##########
@@ -197,7 +199,7 @@ public void testActiveByDefaultProfileRepositoryHonored() {
.session(session)
.requestType(ModelBuilderRequest.RequestType.CONSUMER_DEPENDENCY)
.source(Sources.resolvedSource(
- getPom("active-by-default-profile"), "org.apache.maven.test:active-by-default-profile:1.0.0"))
+ getPom("active-by-default-profile"), "org.apache.maven.tests:active-by-default-profile:1.0.0"))
Review Comment:
Fixed in 5764d1b8c7 — reverted `org.apache.maven.tests` back to `org.apache.maven.test`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix stale Javadoc and GAV typo in external-profile tests (follow-up to #13141) [maven]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on code in PR #13156:
URL: https://github.com/apache/maven/pull/13156#discussion_r4033704718
##########
impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelBuilderTest.java:
##########
@@ -197,7 +199,7 @@ public void testActiveByDefaultProfileRepositoryHonored() {
.session(session)
.requestType(ModelBuilderRequest.RequestType.CONSUMER_DEPENDENCY)
.source(Sources.resolvedSource(
- getPom("active-by-default-profile"), "org.apache.maven.test:active-by-default-profile:1.0.0"))
+ getPom("active-by-default-profile"), "org.apache.maven.tests:active-by-default-profile:1.0.0"))
Review Comment:
**Wrong direction.** Every other `resolvedSource` call in this class uses `org.apache.maven.test` (no `s`) as the modelId — lines 179, 241, 329, 413, etc. This change adds an `s`, introducing a new inconsistency that directly contradicts the PR's stated goal ("matching the fixture and existing test convention").
The POM fixture is correctly being fixed *to* `org.apache.maven.test`. This line should be left unchanged (it's already the right value):
```suggestion
getPom("active-by-default-profile"), "org.apache.maven.test:active-by-default-profile:1.0.0"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix stale Javadoc and GAV typo in external-profile tests (follow-up to #13141) [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #13156:
URL: https://github.com/apache/maven/pull/13156#discussion_r4037936770
##########
impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelBuilderTest.java:
##########
@@ -197,7 +199,7 @@ public void testActiveByDefaultProfileRepositoryHonored() {
.session(session)
.requestType(ModelBuilderRequest.RequestType.CONSUMER_DEPENDENCY)
.source(Sources.resolvedSource(
- getPom("active-by-default-profile"), "org.apache.maven.test:active-by-default-profile:1.0.0"))
+ getPom("active-by-default-profile"), "org.apache.maven.tests:active-by-default-profile:1.0.0"))
Review Comment:
Fixed in 5764d1b8c75deb503efb8537b4589acc66c1cf0c — kept `org.apache.maven.test` (no `s`) in `resolvedSource`, matching the fixture and existing convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix stale Javadoc and GAV typo in external-profile tests (follow-up to #13141) [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #13156:
URL: https://github.com/apache/maven/pull/13156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix stale Javadoc and GAV typo in external-profile tests (follow-up to #13141) [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #13156:
URL: https://github.com/apache/maven/pull/13156#discussion_r4037914937
##########
impl/maven-impl/src/test/java/org/apache/maven/impl/model/DefaultModelBuilderTest.java:
##########
@@ -197,7 +199,7 @@ public void testActiveByDefaultProfileRepositoryHonored() {
.session(session)
.requestType(ModelBuilderRequest.RequestType.CONSUMER_DEPENDENCY)
.source(Sources.resolvedSource(
- getPom("active-by-default-profile"), "org.apache.maven.test:active-by-default-profile:1.0.0"))
+ getPom("active-by-default-profile"), "org.apache.maven.tests:active-by-default-profile:1.0.0"))
Review Comment:
Fixed in 5764d1b8c7: reverted to `org.apache.maven.test` (no 's'), consistent with all other `resolvedSource` calls in the class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org