You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/06/30 07:16:10 UTC
[Impala-ASF-CR] IMPALA-11406: Fix incorrect duration log for authorization
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18682
Change subject: IMPALA-11406: Fix incorrect duration log for authorization
......................................................................
IMPALA-11406: Fix incorrect duration log for authorization
IMPALA-8443 extends EventSequence.markEvent() to return the duration
between the last and the current event. However, the duration is
calculated using the start time, not the last time it's invoked, which
causes misleading time in logs of "Authorization check took n ms".
This fixes the bug and also adds a log for the analysis duration.
Change-Id: I8b665f1b4ac86577711598ce9d845cf82fedbcd7
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M fe/src/main/java/org/apache/impala/util/EventSequence.java
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/18682/1
--
To view, visit http://gerrit.cloudera.org:8080/18682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b665f1b4ac86577711598ce9d845cf82fedbcd7
Gerrit-Change-Number: 18682
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-11406: Fix incorrect duration log for authorization
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18682 )
Change subject: IMPALA-11406: Fix incorrect duration log for authorization
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8330/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b665f1b4ac86577711598ce9d845cf82fedbcd7
Gerrit-Change-Number: 18682
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 18 Jul 2022 05:48:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11406: Fix incorrect duration log for authorization
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18682 )
Change subject: IMPALA-11406: Fix incorrect duration log for authorization
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b665f1b4ac86577711598ce9d845cf82fedbcd7
Gerrit-Change-Number: 18682
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 15 Jul 2022 10:40:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11406: Fix incorrect duration log for authorization
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18682 )
Change subject: IMPALA-11406: Fix incorrect duration log for authorization
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b665f1b4ac86577711598ce9d845cf82fedbcd7
Gerrit-Change-Number: 18682
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 18 Jul 2022 05:48:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11406: Fix incorrect duration log for authorization
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18682 )
Change subject: IMPALA-11406: Fix incorrect duration log for authorization
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b665f1b4ac86577711598ce9d845cf82fedbcd7
Gerrit-Change-Number: 18682
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 18 Jul 2022 10:35:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11406: Fix incorrect duration log for authorization
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18682 )
Change subject: IMPALA-11406: Fix incorrect duration log for authorization
......................................................................
Patch Set 1:
Thank Tamas's review!
--
To view, visit http://gerrit.cloudera.org:8080/18682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b665f1b4ac86577711598ce9d845cf82fedbcd7
Gerrit-Change-Number: 18682
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 15 Jul 2022 10:39:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11406: Fix incorrect duration log for authorization
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18682 )
Change subject: IMPALA-11406: Fix incorrect duration log for authorization
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8317/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b665f1b4ac86577711598ce9d845cf82fedbcd7
Gerrit-Change-Number: 18682
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 15 Jul 2022 10:40:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11406: Fix incorrect duration log for authorization
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18682 )
Change subject: IMPALA-11406: Fix incorrect duration log for authorization
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10901/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b665f1b4ac86577711598ce9d845cf82fedbcd7
Gerrit-Change-Number: 18682
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 30 Jun 2022 07:35:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11406: Fix incorrect duration log for authorization
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18682 )
Change subject: IMPALA-11406: Fix incorrect duration log for authorization
......................................................................
Patch Set 1: Code-Review+2
Hi Quanlong,
nice catch! LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/18682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b665f1b4ac86577711598ce9d845cf82fedbcd7
Gerrit-Change-Number: 18682
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Fri, 15 Jul 2022 10:10:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11406: Fix incorrect duration log for authorization
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18682 )
Change subject: IMPALA-11406: Fix incorrect duration log for authorization
......................................................................
IMPALA-11406: Fix incorrect duration log for authorization
IMPALA-8443 extends EventSequence.markEvent() to return the duration
between the last and the current event. However, the duration is
calculated using the start time, not the last time it's invoked, which
causes misleading time in logs of "Authorization check took n ms".
This fixes the bug and also adds a log for the analysis duration.
Change-Id: I8b665f1b4ac86577711598ce9d845cf82fedbcd7
Reviewed-on: http://gerrit.cloudera.org:8080/18682
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java
M fe/src/main/java/org/apache/impala/util/EventSequence.java
2 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b665f1b4ac86577711598ce9d845cf82fedbcd7
Gerrit-Change-Number: 18682
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>