You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/11 15:05:18 UTC

[GitHub] [skywalking] whfjam commented on issue #5291: since the issue #4907 i think the class RestMappingMethodInterceptor should implements the method “getAcceptedMethodTypes”

whfjam commented on issue #5291:
URL: https://github.com/apache/skywalking/issues/5291#issuecomment-672001820


   > 
   > 
   > I think #5084 has fixed this.
   
   in #5084 it changed the code in the class AbstractMethodInterceptor use “getAcceptedMethodTypes(method)” but the method “getAcceptedMethodTypes” is a abstract one ，the implements are RequestMappingMethodInterceptor.getAcceptedMethodTypes and RestMappingMethodInterceptor.getAcceptedMethodTypes，then the RequestMappingMethodInterceptor.getAcceptedMethodTypes has handle the case but  the RestMappingMethodInterceptor.getAcceptedMethodTypes just return a empty string, did i miss something..
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org