[GitHub] cloudstack pull request #1642: System VMs on Managed Storage

[jburwell <gi...@git.apache.org>]

Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1642#discussion_r78780699
  
    --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
    @@ -1113,8 +1114,17 @@ public void cleanupStorage(boolean recurring) {
                         cleanupSecondaryStorage(recurring);
     
                         List<VolumeVO> vols = _volsDao.listVolumesToBeDestroyed(new Date(System.currentTimeMillis() - ((long) StorageCleanupDelay.value() << 10)));
    +
                         for (VolumeVO vol : vols) {
                             try {
    +                            // If this fails, just log a warning. It's ideal if we clean up the host-side clustered file
    +                            // system, but not necessary.
    +                            handleManagedStorage(vol);
    +                        } catch (Exception e) {
    --- End diff --
    
    Why are all checked and unchecked exceptions being caught here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---