[GitHub] [airflow] eladkal commented on a change in pull request #21700: fix keys in type map in presto_to_gcs & trino_to_gcs operators

[GitBox <gi...@apache.org>]

eladkal commented on a change in pull request #21700:
URL: https://github.com/apache/airflow/pull/21700#discussion_r820499218



##########
File path: airflow/providers/google/cloud/transfers/presto_to_gcs.py
##########
@@ -150,12 +150,12 @@ class PrestoToGCSOperator(BaseSQLToGCSOperator):
 
     type_map = {
         "BOOLEAN": "BOOL",
-        "TINYINT": "INT64",
-        "SMALLINT": "INT64",
-        "INTEGER": "INT64",
-        "BIGINT": "INT64",
-        "REAL": "FLOAT64",
-        "DOUBLE": "FLOAT64",
+        "TINYINT": "INTEGER",

Review comment:
       Can you give more context to what is the bug?
   
   I believe that the goal was to make the files in GCS to be compatible with BigQuery (to allow uploading to BigQuery right after)
   These are all aliases:
   `INT, SMALLINT, INTEGER, BIGINT, TINYINT, and BYTEINT are aliases for INT64.
   `https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org