You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by RomainNaour <gi...@git.apache.org> on 2015/04/25 18:29:29 UTC

[GitHub] thrift pull request: Thrift 3113 c++11 check issue

GitHub user RomainNaour opened a pull request:

    https://github.com/apache/thrift/pull/462

    Thrift 3113 c++11 check issue

    The ax_cxx_compile_stdcxx_11 macro bundled in thrift package is broken [1] and out of date. Since Thrift actually doesn't use that particular C+11 feature, make C+11 support optional.
    Also, add two patches added by Gustavo Zacarias used to cross-compile thrift.
    [1] https://savannah.gnu.org/patch/index.php?8287


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/RomainNaour/thrift THRIFT-3113-C++11-check-issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #462
    
----
commit 8d8c00624fef161fcf924bc3d3b6df01995e8272
Author: Gustavo Zacarias <gu...@zacarias.com.ar>
Date:   2015-04-25T15:53:28Z

    Make it cross-compile happy the hard way, there's no clean way.
    
    Signed-off-by: Gustavo Zacarias <gu...@zacarias.com.ar>
    Signed-off-by: Romain Naour <ro...@openwide.fr>

commit 5efcf275a9e146a317a11b845238ffcafcc53f2f
Author: Gustavo Zacarias <gu...@zacarias.com.ar>
Date:   2015-04-25T15:57:10Z

    Make zlib version detection cross-compile happy.
    
    Signed-off-by: Gustavo Zacarias <gu...@zacarias.com.ar>
    Signed-off-by: Romain Naour <ro...@openwide.fr>

commit f4694e409c9117c3c9b274f22d1204365373d3eb
Author: Romain Naour <ro...@openwide.fr>
Date:   2015-04-07T05:37:26Z

    autotools: update ax_cxx_compile_stdcxx_11.m4 to version 10
    
    The ax_cxx_compile_stdcxx_11 macro bundled in thrift package is
    brocken [1] and out of date.
    
    Since Thrift actually doesn't use that particular C++11 feature,
    make C++11 support optional.
    
    [1] https://savannah.gnu.org/patch/index.php?8287
    
    Fixes:
    [thrift]
    http://autobuild.buildroot.net/results/21e/21e3fff1e0d714f94ac7e621289d1a59bc02a05f/build-end.log
    [host-thrift]
    http://autobuild.buildroot.net/results/b89/b89ffc2bff699eb10bb6abd92369a43d4900354d/build-end.log
    
    Signed-off-by: Romain Naour <ro...@openwide.fr>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Thrift 3113 c++11 check issue

Posted by RomainNaour <gi...@git.apache.org>.

Github user RomainNaour commented on the pull request:

    https://github.com/apache/thrift/pull/462#issuecomment-96394161
  
    Thanks !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Thrift 3113 c++11 check issue

Posted by bufferoverflow <gi...@git.apache.org>.

Github user bufferoverflow commented on the pull request:

    https://github.com/apache/thrift/pull/462#issuecomment-96393589
  
    committed, please close the issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Thrift 3113 c++11 check issue

Posted by RomainNaour <gi...@git.apache.org>.

Github user RomainNaour closed the pull request at:

    https://github.com/apache/thrift/pull/462


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---