You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ce...@apache.org on 2019/10/25 04:36:58 UTC

svn commit: r1868897 - in /poi/trunk/src: scratchpad/src/org/apache/poi/hemf/record/emfplus/HemfPlusDraw.java testcases/org/apache/poi/ss/util/TestExpandedDouble.java

Author: centic
Date: Fri Oct 25 04:36:58 2019
New Revision: 1868897

URL: http://svn.apache.org/viewvc?rev=1868897&view=rev
Log:
Bug 63805: BigDecimal: use enum args instead of integers (deprecated in Java 9)

Modified:
    poi/trunk/src/scratchpad/src/org/apache/poi/hemf/record/emfplus/HemfPlusDraw.java
    poi/trunk/src/testcases/org/apache/poi/ss/util/TestExpandedDouble.java

Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hemf/record/emfplus/HemfPlusDraw.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hemf/record/emfplus/HemfPlusDraw.java?rev=1868897&r1=1868896&r2=1868897&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hemf/record/emfplus/HemfPlusDraw.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hemf/record/emfplus/HemfPlusDraw.java Fri Oct 25 04:36:58 2019
@@ -28,6 +28,7 @@ import java.awt.geom.Rectangle2D;
 import java.awt.image.BufferedImage;
 import java.io.IOException;
 import java.math.BigDecimal;
+import java.math.RoundingMode;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.LinkedHashMap;
@@ -789,7 +790,7 @@ public class HemfPlusDraw {
 
 
     static double round10(double d) {
-        return new BigDecimal(d).setScale(10, BigDecimal.ROUND_HALF_UP).doubleValue();
+        return new BigDecimal(d).setScale(10, RoundingMode.HALF_UP).doubleValue();
     }
 
     static int readRectS(LittleEndianInputStream leis, Rectangle2D bounds) {

Modified: poi/trunk/src/testcases/org/apache/poi/ss/util/TestExpandedDouble.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/util/TestExpandedDouble.java?rev=1868897&r1=1868896&r2=1868897&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/util/TestExpandedDouble.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/util/TestExpandedDouble.java Fri Oct 25 04:36:58 2019
@@ -21,6 +21,7 @@ import static org.junit.Assert.assertEqu
 
 import java.math.BigDecimal;
 import java.math.BigInteger;
+import java.math.RoundingMode;
 
 import org.apache.poi.util.HexDump;
 import org.junit.Test;
@@ -152,7 +153,7 @@ public final class TestExpandedDouble {
 		BigDecimal bd = new BigDecimal(hd.getSignificand()).divide(new BigDecimal(BigInteger.ONE.shiftLeft(gg)));
 		int excessPrecision = bd.precision() - 23;
 		if (excessPrecision > 0) {
-			bd = bd.setScale(bd.scale() - excessPrecision, BigDecimal.ROUND_HALF_UP);
+			bd = bd.setScale(bd.scale() - excessPrecision, RoundingMode.HALF_UP);
 		}
 		return bd.unscaledValue().toString();
 	}
@@ -189,7 +190,7 @@ public final class TestExpandedDouble {
 		}
 		int excessPrecision = bd.precision() - nDec;
 		if (excessPrecision > 0) {
-			bd = bd.setScale(bd.scale() - excessPrecision, BigDecimal.ROUND_HALF_UP);
+			bd = bd.setScale(bd.scale() - excessPrecision, RoundingMode.HALF_UP);
 		}
 		return bd.unscaledValue();
 	}



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org