You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by SrikanteswaraRao Talluri <sr...@citrix.com> on 2013/11/04 10:13:29 UTC

Re: Review Request 14199: Adding missing test cases: Snapshots Improvement

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review28090
-----------------------------------------------------------


is_snapshot_on_nfs method is returning error. NFS export path is wrongly framed in utils.py

Cmd: mount -t nfs 10.147.28.7/export/home/talluri/vmware.campo/secondary /mnt/tmp via Host: 10.147.38.207} {returns: ["mount.nfs: remote share not in 'host:dir' format"]}

- SrikanteswaraRao Talluri


On Oct. 31, 2013, 5:04 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 5:04 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, suresh sadhu, and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_snapshots_improvement.py PRE-CREATION 
>   tools/marvin/marvin/asyncJobMgr.py 25818a6 
> 
> Diff: https://reviews.apache.org/r/14199/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on KVM Advanced setup.
> 
> test_01_concurrent_snapshots_live_migrate (test_snapshots_improvement.TestCreateSnapshot)
> Test perform concurrent snapshots and migrate the vm from one host ... ok
> test_02_stop_vm_concurrent_snapshots (test_snapshots_improvement.TestCreateSnapshot)
> Test stop running VM while performing concurrent snapshot on volume ... ok
> test_03_concurrent_snapshots_create_template (test_snapshots_improvement.TestCreateSnapshot)
> Test while parent concurrent snapshot job in progress,create ... ok
> test_04_concurrent_snapshots_create_volume (test_snapshots_improvement.TestCreateSnapshot)
> Test while parent concurrent snapshot job in progress,create volume ... ok
> test_01_snapshot_on_rootVolume (test_snapshots_improvement.TestSnapshotOnRootVolume)
> Test create VM with default cent os template and create snapshot ... ok
> 
> ----------------------------------------------------------------------
> Ran 5 tests in 1420.575s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 14199: Adding missing test cases: Snapshots Improvement

Posted by Gaurav Aradhye <ga...@clogeny.com>.

> On Nov. 4, 2013, 2:43 p.m., SrikanteswaraRao Talluri wrote:
> > is_snapshot_on_nfs method is returning error. NFS export path is wrongly framed in utils.py
> > 
> > Cmd: mount -t nfs 10.147.28.7/export/home/talluri/vmware.campo/secondary /mnt/tmp via Host: 10.147.38.207} {returns: ["mount.nfs: remote share not in 'host:dir' format"]}

Hi Talluri,

This issue arises when the Image url is not in proper format. As you can see, in above URL, colon is missing after the ip address. I had already logged this issue here: https://issues.apache.org/jira/browse/CLOUDSTACK-4741

This issue is inconsistent and now even I am not able to reproduce it on any setup. As you have encountered this, can you reopen it and please share the details of the setup?


- Gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14199/#review28090
-----------------------------------------------------------


On Oct. 31, 2013, 10:34 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14199/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 10:34 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, suresh sadhu, and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding 5 missing test cases.
> Change in asyncJobMgr.py >> the method "make_request" in cloudstackConnection does not exist now. Replaced it by "marvin_request". Checked running async jobs with this change. Works correctly.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_snapshots_improvement.py PRE-CREATION 
>   tools/marvin/marvin/asyncJobMgr.py 25818a6 
> 
> Diff: https://reviews.apache.org/r/14199/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on KVM Advanced setup.
> 
> test_01_concurrent_snapshots_live_migrate (test_snapshots_improvement.TestCreateSnapshot)
> Test perform concurrent snapshots and migrate the vm from one host ... ok
> test_02_stop_vm_concurrent_snapshots (test_snapshots_improvement.TestCreateSnapshot)
> Test stop running VM while performing concurrent snapshot on volume ... ok
> test_03_concurrent_snapshots_create_template (test_snapshots_improvement.TestCreateSnapshot)
> Test while parent concurrent snapshot job in progress,create ... ok
> test_04_concurrent_snapshots_create_volume (test_snapshots_improvement.TestCreateSnapshot)
> Test while parent concurrent snapshot job in progress,create volume ... ok
> test_01_snapshot_on_rootVolume (test_snapshots_improvement.TestSnapshotOnRootVolume)
> Test create VM with default cent os template and create snapshot ... ok
> 
> ----------------------------------------------------------------------
> Ran 5 tests in 1420.575s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>