[jira] [Commented] (NIFI-504) Build processor to geo-enrich IP addresses

["Joseph Witt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488880#comment-14488880 ] 

Joseph Witt commented on NIFI-504:
----------------------------------

+0.

A licensing issue (simple to fix):
Since we've copied the DatabaseReader.java of maxmind to fix their use of exceptions for flow control we must account for that sufficiently.  Take a look here:
http://www.apache.org/legal/src-headers.html#headers

It calls out that we should not add the license header to that file.  So that must be removed since it was not in their original.  

I think that is the only issue.  I looked into whether we need to add their copyright line to our notice and do not believe it is necessary.

The other concern i have is pushing this in with zero unit tests.  We should probably have a simple pre-canned dataset and do a couple unit tests w/edge cases to round it out.

> Build processor to geo-enrich IP addresses
> ------------------------------------------
>
>                 Key: NIFI-504
>                 URL: https://issues.apache.org/jira/browse/NIFI-504
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Mark Payne
>             Fix For: 0.1.0
>
>         Attachments: 0006-504-Initial-import-of-geo-enrich-processors.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)