You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/28 12:00:19 UTC

[GitHub] [airflow] ephraimbuddy opened a new pull request, #23325: Ignore `dev/` when releasing source code

ephraimbuddy opened a new pull request, #23325:
URL: https://github.com/apache/airflow/pull/23325

   Ignore `dev/` directory for future releases


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #23325: Ignore `dev/` when releasing source code

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on code in PR #23325:
URL: https://github.com/apache/airflow/pull/23325#discussion_r861232472


##########
.gitattributes:
##########
@@ -1,3 +1,50 @@
-tests/** export-ignore
-tests/ export-ignore

Review Comment:
   I found that we don't need to specify `tests/**` and `tests/` in other to ignore the `tests` directory. Specifying the directory name without patterns works. I will like another person to verify this as I don't know if it was because of my git version.
   
   Also, I updated the entry to be alphabetical a bit(not perfect though)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ephraimbuddy commented on pull request #23325: Ignore `dev/` when releasing source code

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on PR #23325:
URL: https://github.com/apache/airflow/pull/23325#issuecomment-1112530048

   I think we should also ignore these?:
   - breeze-legacy 
   - breeze-complete 
   - ISSUE_TRIAGE_PROCESS.rst 
   - PULL_REQUEST_WORKFLOW.rst
   - SELECTIVE_CHECKS.md
   - STATIC_CODE_CHECKS.rst 
   - TESTING.rst 
   - LOCAL_VIRTUALENV.rst 
   - CONTRIBUTING.rst
   - BREEZE.rst
   - CI.rst
   - CI_DIAGRAMS.md
   - CONTRIBUTORS_QUICK_START.rst
   - codecov.yml 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #23325: Ignore some files/directory when releasing source code

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23325:
URL: https://github.com/apache/airflow/pull/23325#issuecomment-1113602931

   Case for splitting repos :) ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #23325: Ignore some files/directory when releasing source code

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23325:
URL: https://github.com/apache/airflow/pull/23325#issuecomment-1112598714

   The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ephraimbuddy merged pull request #23325: Ignore some files/directory when releasing source code

Posted by GitBox <gi...@apache.org>.
ephraimbuddy merged PR #23325:
URL: https://github.com/apache/airflow/pull/23325


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a diff in pull request #23325: Ignore some files/directory when releasing source code

Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #23325:
URL: https://github.com/apache/airflow/pull/23325#discussion_r862017712


##########
.gitattributes:
##########
@@ -1,3 +1,50 @@
-tests/** export-ignore
-tests/ export-ignore
-chart/tests export-ignore
+airflow/providers export-ignore
+breeze export-ignore
+breeze-legacy export-ignore
+breeze-complete export-ignore
+chart export-ignore

Review Comment:
   good point



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #23325: Ignore some files/directory when releasing source code

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on code in PR #23325:
URL: https://github.com/apache/airflow/pull/23325#discussion_r862034802


##########
.gitattributes:
##########
@@ -1,3 +1,50 @@
-tests/** export-ignore
-tests/ export-ignore
-chart/tests export-ignore
+airflow/providers export-ignore
+breeze export-ignore
+breeze-legacy export-ignore
+breeze-complete export-ignore
+chart export-ignore

Review Comment:
   Very good call. 
   Thanks Jed. It affected chart. I had to remove providers too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #23325: Ignore `dev/` when releasing source code

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on code in PR #23325:
URL: https://github.com/apache/airflow/pull/23325#discussion_r861233310


##########
.gitattributes:
##########
@@ -1,3 +1,50 @@
-tests/** export-ignore
-tests/ export-ignore

Review Comment:
   Tested with:
   ```
   mkdir dist
   git archive --format=tar.gz HEAD \
       --prefix=apache-airflow-test/ \
       -o dist/apache-airflow-test-source.tar.gz
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jedcunningham commented on a diff in pull request #23325: Ignore some files/directory when releasing source code

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #23325:
URL: https://github.com/apache/airflow/pull/23325#discussion_r862005551


##########
.gitattributes:
##########
@@ -1,3 +1,50 @@
-tests/** export-ignore
-tests/ export-ignore
-chart/tests export-ignore
+airflow/providers export-ignore
+breeze export-ignore
+breeze-legacy export-ignore
+breeze-complete export-ignore
+chart export-ignore

Review Comment:
   Did you test this for the chart release steps? The chart also uses `git archive`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org