[jira] [Commented] (CALCITE-4364) Simplify "a IN (1, 2) AND a = 1" to "a = 1"

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229426#comment-17229426 ] 

Julian Hyde commented on CALCITE-4364:
--------------------------------------

The new {{flattenOperands}} is very similar to existing {{composeConjunction}} and {{flattenAnd}} methods in {{RexUtil}}. Could you somehow re-use those methods? Perhaps if you handle AND and OR separately.

The {{canNotMerge}} method (dealing with 3-valued logic) is much needed. But are there tests for it?

Can you reverse the sense of it, to {{canMerge?}}

> Simplify "a IN (1, 2) AND a = 1" to "a = 1"
> -------------------------------------------
>
>                 Key: CALCITE-4364
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4364
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.26.0
>            Reporter: Danny Chen
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.27.0
>
>          Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> Calcite should simplify "\{{a IN (1, 2) AND a = 1}}" to "\{{a = 1}}". Check this test in {{RexProgramTest}}:
> {code:java}
> @Test void testSimplifyInAnd() {
>     // deptno in (20, 10) and deptno = 10
>     //   ==>
>     // deptno = 10
>     final RexNode e =
>         and(
>             in(vInt(), literal(20), literal(10)),
>             eq(vInt(), literal(10)));
>     checkSimplify(e, "=(?0.int0, 10)");
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)