You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2014/05/12 13:21:58 UTC

svn commit: r1593927 - in /httpcomponents/httpasyncclient/trunk/httpasyncclient/src: main/java/org/apache/http/impl/nio/client/HttpAsyncClientBuilder.java test/java/org/apache/http/nio/client/integration/TestHttpAsync.java

Author: olegk
Date: Mon May 12 11:21:58 2014
New Revision: 1593927

URL: http://svn.apache.org/r1593927
Log:
Use a separate setter for shared connection manager flag

Modified:
    httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/HttpAsyncClientBuilder.java
    httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsync.java

Modified: httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/HttpAsyncClientBuilder.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/HttpAsyncClientBuilder.java?rev=1593927&r1=1593926&r2=1593927&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/HttpAsyncClientBuilder.java (original)
+++ httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/HttpAsyncClientBuilder.java Mon May 12 11:21:58 2014
@@ -206,25 +206,25 @@ public class HttpAsyncClientBuilder {
      */
     public final HttpAsyncClientBuilder setConnectionManager(
             final NHttpClientConnectionManager connManager) {
-        return setConnectionManager(connManager, false);
+        this.connManager = connManager;
+        return this;
     }
 
     /**
-     * Assigns {@link NHttpClientConnectionManager} instance.
+     * Defines the connection manager is to be shared by multiple
+     * client instances.
      * <p/>
      * If the connection manager is shared its life-cycle is expected
      * to be managed by the caller and it will not be shut down
      * if the client is closed.
      *
-     * @param connManager connection manager
      * @param shared defines whether or not the connection manager can be shared
      *  by multiple clients.
      *
      * @since 4.1
      */
-    public final HttpAsyncClientBuilder setConnectionManager(
-            final NHttpClientConnectionManager connManager, final boolean shared) {
-        this.connManager = connManager;
+    public final HttpAsyncClientBuilder setConnectionManagerShared(
+            final boolean shared) {
         this.connManagerShared = shared;
         return this;
     }

Modified: httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsync.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsync.java?rev=1593927&r1=1593926&r2=1593927&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsync.java (original)
+++ httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsync.java Mon May 12 11:21:58 2014
@@ -255,7 +255,8 @@ public class TestHttpAsync extends HttpA
 
 
         final CloseableHttpAsyncClient httpclient2 = HttpAsyncClients.custom()
-                .setConnectionManager(this.connMgr, true)
+                .setConnectionManager(this.connMgr)
+                .setConnectionManagerShared(true)
                 .build();
         try {
             httpclient2.start();