[GitHub] [flink] TisonKun edited a comment on issue #10413: [FLINK-15039][FLINK-15041] Remove default ClusterClient and JobClient close() implementations

[GitBox <gi...@apache.org>]

TisonKun edited a comment on issue #10413: [FLINK-15039][FLINK-15041] Remove default ClusterClient and JobClient close() implementations
URL: https://github.com/apache/flink/pull/10413#issuecomment-561515078
 
 
   Here I will share one thought about these `close` things. I notice that the default behavior of `ClusterClientJobClientAdapter#close` is calling `ClusterClient#close`. So I used to make the default implementation of `ClusterClientJobClientAdapter#doClose` calling `ClusterClient#close`. However, then subclasses should think of calling `super.doClose`, which is an overhead then we directly let user define the whole behavior. At the end I give up for changing current implementation but it's a somehow valid thought.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services