You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/08 15:24:45 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #13814: ARROW-17304: [C++][Compute] Print actual values when compare fails in aggregate test

pitrou commented on code in PR #13814:
URL: https://github.com/apache/arrow/pull/13814#discussion_r940371679


##########
cpp/src/arrow/compute/kernels/aggregate_test.cc:
##########
@@ -2543,7 +2543,9 @@ void CheckModes(const Datum& array, const ModeOptions options,
   for (int i = 0; i < out_array.length(); ++i) {

Review Comment:
   Could perhaps also add `ARROW_SCOPED_TRACE("Mode options = ", options.ToString())` somewhere above to provide better insight into what is computed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org