You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "DavidLiu001 (via GitHub)" <gi...@apache.org> on 2023/03/22 13:44:03 UTC
[GitHub] [flink] DavidLiu001 opened a new pull request, #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
DavidLiu001 opened a new pull request, #22241:
URL: https://github.com/apache/flink/pull/22241
…eturning result
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Fix the semantics issue of the method of FatalExceptionClassifier#isFatal
## Brief change log
Change the method of isFatal(), It returns `true` if the passed throwable is fatal and `false` if it is not.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vtkhanh commented on pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "vtkhanh (via GitHub)" <gi...@apache.org>.
vtkhanh commented on PR #22241:
URL: https://github.com/apache/flink/pull/22241#issuecomment-1486819603
> @vtkhanh, Can this PR be merged?
Hi, I dont have permission to merge your PR. You need to ask @dannycranmer for the approval and to merge your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DavidLiu001 commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "DavidLiu001 (via GitHub)" <gi...@apache.org>.
DavidLiu001 commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1155076533
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,13 +44,13 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
- return false;
+ return true;
Review Comment:
@dannycranmer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vtkhanh commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "vtkhanh (via GitHub)" <gi...@apache.org>.
vtkhanh commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1148124903
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,6 +44,8 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
+ return true;
+ } else {
Review Comment:
Dont think we should return `false` right after validator.test is `false` as it wont go into `chainedClassifier` check. Instead, we should return false at the line 55.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DavidLiu001 commented on pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "DavidLiu001 (via GitHub)" <gi...@apache.org>.
DavidLiu001 commented on PR #22241:
URL: https://github.com/apache/flink/pull/22241#issuecomment-1482158456
@flinkbot please run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DavidLiu001 commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "DavidLiu001 (via GitHub)" <gi...@apache.org>.
DavidLiu001 commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1153204649
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,13 +44,13 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
- return false;
+ return true;
Review Comment:
@dannycranmer you means `@Deprecate` the existing implementation with `return false` , introduce a new method with the same name of `isFatal` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DavidLiu001 commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "DavidLiu001 (via GitHub)" <gi...@apache.org>.
DavidLiu001 commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1148303070
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,6 +44,8 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
+ return true;
+ } else {
Review Comment:
> Dont think we should return `false` right after validator.test is `false` as it wont go into `chainedClassifier` check. Instead, we should return false at the line 55.
Good comment, PR was updated. A little difference, `chainedClassifier` check includes `false` and `true`, It seems that new "return false" is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vtkhanh commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "vtkhanh (via GitHub)" <gi...@apache.org>.
vtkhanh commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1148335744
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,6 +44,8 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
+ return true;
+ } else {
Review Comment:
> > Dont think we should return `false` right after validator.test is `false` as it wont go into `chainedClassifier` check. Instead, we should return false at the line 55.
> > Good comment, PR was updated. A little difference, `chainedClassifier` check includes `false` and `true`, It seems that new "return false" is not needed.
If we carry on to `chainedClassifier` check, the result is being `false`, isn't it? so if there is nothing to check from `chainedClassifier` (`chainedClassifier` is `null`), shouldn't we return `false`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DavidLiu001 commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "DavidLiu001 (via GitHub)" <gi...@apache.org>.
DavidLiu001 commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1148340558
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,6 +44,8 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
+ return true;
+ } else {
Review Comment:
> > > Dont think we should return `false` right after validator.test is `false` as it wont go into `chainedClassifier` check. Instead, we should return false at the line 55.
> > > Good comment, PR was updated. A little difference, `chainedClassifier` check includes `false` and `true`, It seems that new "return false" is not needed.
>
> If we carry on to `chainedClassifier` check, the result is being `false`, isn't it? so if there is nothing to check from `chainedClassifier` (`chainedClassifier` is `null`), shouldn't we return `false`?
Good discussion. Since `chainedClassifier` is a private memeber of FatalExceptionClassifier and when a chain is created, there is `chainedClassifier` to be used, if `chainedClassifier` is `null`, it can cause fatal exception. When `chainedClassifier` is `null`, do you think we should return `false` not `true` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vtkhanh commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "vtkhanh (via GitHub)" <gi...@apache.org>.
vtkhanh commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1148126469
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,6 +44,8 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
+ return true;
+ } else {
Review Comment:
And should we add unit tests for this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22241:
URL: https://github.com/apache/flink/pull/22241#issuecomment-1479607436
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1351542fe6562235a0b262d0ebbf6319d7816bac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1351542fe6562235a0b262d0ebbf6319d7816bac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1351542fe6562235a0b262d0ebbf6319d7816bac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DavidLiu001 commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "DavidLiu001 (via GitHub)" <gi...@apache.org>.
DavidLiu001 commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1148340558
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,6 +44,8 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
+ return true;
+ } else {
Review Comment:
> > > Dont think we should return `false` right after validator.test is `false` as it wont go into `chainedClassifier` check. Instead, we should return false at the line 55.
> > > Good comment, PR was updated. A little difference, `chainedClassifier` check includes `false` and `true`, It seems that new "return false" is not needed.
>
> If we carry on to `chainedClassifier` check, the result is being `false`, isn't it? so if there is nothing to check from `chainedClassifier` (`chainedClassifier` is `null`), shouldn't we return `false`?
Good discussion. Since `chainedClassifier` is a private memeber of `FatalExceptionClassifier` and when a chain is created, there is `chainedClassifier` to be used, if `chainedClassifier` is `null`, it can cause fatal exception. When `chainedClassifier` is `null`, do you think we should return `false` not `true` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DavidLiu001 commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "DavidLiu001 (via GitHub)" <gi...@apache.org>.
DavidLiu001 commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1148303506
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,6 +44,8 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
+ return true;
+ } else {
Review Comment:
> And should we add unit tests for this method?
The previous test cases related to `FatalExceptionClassifier` has covered `isFatal` method, this PR is a minor change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DavidLiu001 commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "DavidLiu001 (via GitHub)" <gi...@apache.org>.
DavidLiu001 commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1153204649
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,13 +44,13 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
- return false;
+ return true;
Review Comment:
@dannycranmer you means `@Deprecate` the existing implementation with `return false` , introduce new method with the same `isFatal` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1164228321
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,13 +44,13 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
- return false;
+ return true;
Review Comment:
> Can you please add a test for this or raise a Jira to cover that?
I would say that a test must be added before a PR like this can be merged. We shouldn't do this later.
@dannycranmer If this is `@Internal` I think we can break it between versions, unless there are things that rely on this and it actually should have been made public. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vtkhanh commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "vtkhanh (via GitHub)" <gi...@apache.org>.
vtkhanh commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1149125548
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,6 +44,8 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
+ return true;
+ } else {
Review Comment:
yes, I think it should return `false` if `chainedClassifier` is `null`, it's not because null `chainedClassifier` can cause fatal exception, it's because we should maintain/keep the `false` result after the `validator.test` returns `false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DavidLiu001 commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "DavidLiu001 (via GitHub)" <gi...@apache.org>.
DavidLiu001 commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1149296225
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,6 +44,8 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
+ return true;
+ } else {
Review Comment:
Okay，PR was updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DavidLiu001 commented on pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "DavidLiu001 (via GitHub)" <gi...@apache.org>.
DavidLiu001 commented on PR #22241:
URL: https://github.com/apache/flink/pull/22241#issuecomment-1486346460
@vtkhanh, Can this PR be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1150564908
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,13 +44,13 @@ public FatalExceptionClassifier(
public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
if (validator.test(err)) {
throwableConsumer.accept(throwableMapper.apply(err));
- return false;
+ return true;
Review Comment:
@DavidLiu001 thanks for the PR but this change is very dangerous as-is, since we are inverting the semantics of the code. This is not a backward compatible change. Instead of changing this, can we 1/ `@Deprecate` the existing implementation and 2/ introduce new code that is cleaner. We can remove the deprecated version in a future Flink version.
Side comment I am concerned that no tests failed with this! Seems there is a gap in the unit tests. Can you please add a test for this or raise a Jira to cover that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org