You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by zregvart <gi...@git.apache.org> on 2017/04/27 12:42:10 UTC
[GitHub] camel pull request #1666: CAMEL-11212 Don't allow Salesforce HTTP client to ...
GitHub user zregvart opened a pull request:
https://github.com/apache/camel/pull/1666
CAMEL-11212 Don't allow Salesforce HTTP client to stop with outstanding requests
Submitted for review, it seems trivial but could have repercussions if I missed the locking semantics.
Thank you for taking a look \U0001f947
This introduces a `Phaser` to await for any in-flight requests to complete before the client is allowed to stop.
This should not block as long as the `BufferingResponseListener::onComplete` is invoked at the end of every request. And that is guaranteed by the `CompleteListener::onComplete` contract.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zregvart/camel CAMEL-11212
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1666.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1666
----
commit e5b137d4b2ec9371a6f8a0a7fca3849730127302
Author: Zoran Regvart <zr...@apache.org>
Date: 2017-04-27T12:40:18Z
CAMEL-11212 Don't allow Salesforce HTTP client ...
...to stop with outstanding requests
This introduces a `Phaser` to await for any in-flight requests to
complete before the client is allowed to stop.
This should not block as long as the
`BufferingResponseListener::onComplete` is invoked at the end of every
request. And that is guaranteed by the `CompleteListener::onComplete`
contract.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] camel pull request #1666: CAMEL-11212 Don't allow Salesforce HTTP client to ...
Posted by zregvart <gi...@git.apache.org>.
Github user zregvart closed the pull request at:
https://github.com/apache/camel/pull/1666
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---