You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/18 03:18:22 UTC

[GitHub] [flink] WeiZhong94 commented on a change in pull request #10567: [FLINK-15244][FileSystems] Fix the bug that FileUtils#deleteDirectoryInternal will delete files in the symbolic link which point to a directory.

WeiZhong94 commented on a change in pull request #10567: [FLINK-15244][FileSystems] Fix the bug that FileUtils#deleteDirectoryInternal will delete files in the symbolic link which point to a directory.
URL: https://github.com/apache/flink/pull/10567#discussion_r359135266
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/util/FileUtils.java
 ##########
 @@ -315,7 +315,11 @@ private static void deleteFileOrDirectoryInternal(File file) throws IOException
 	}
 
 	private static void deleteDirectoryInternal(File directory) throws IOException {
 
 Review comment:
   Yes it makes more sense to check if the directory is symbolic link in `cleanDirectoryInternal `. I have updated current implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services