You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ti...@apache.org on 2019/08/11 09:46:37 UTC
[maven] branch master updated: small refactoring in
StringSearchModelInterpolator (removed unnecessary 'public' modifier in
private class,
inlined variable declaration in loop - not reachable after the loop)
This is an automated email from the ASF dual-hosted git repository.
tibordigana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven.git
The following commit(s) were added to refs/heads/master by this push:
new 829a2c9 small refactoring in StringSearchModelInterpolator (removed unnecessary 'public' modifier in private class, inlined variable declaration in loop - not reachable after the loop)
829a2c9 is described below
commit 829a2c9aae09ed3bca2b7e86370d6f69a44688db
Author: tibordigana <ti...@apache.org>
AuthorDate: Sun Aug 11 11:46:28 2019 +0200
small refactoring in StringSearchModelInterpolator (removed unnecessary 'public' modifier in private class, inlined variable declaration in loop - not reachable after the loop)
---
.../model/interpolation/StringSearchModelInterpolator.java | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java b/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java
index ee5c8b0..c5cd1d2 100644
--- a/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java
+++ b/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java
@@ -143,9 +143,7 @@ public class StringSearchModelInterpolator
{
this.interpolationTargets = new LinkedList<>();
interpolationTargets.add( target );
-
this.interpolator = interpolator;
-
this.problems = problems;
}
@@ -303,7 +301,7 @@ public class StringSearchModelInterpolator
this.fields = fields.toArray( new CacheField[0] );
}
- public void interpolate( Object target, InterpolateObjectAction interpolateObjectAction )
+ void interpolate( Object target, InterpolateObjectAction interpolateObjectAction )
{
for ( CacheField field : fields )
{
@@ -399,12 +397,9 @@ public class StringSearchModelInterpolator
return;
}
- int size = c.size();
- Object value;
- for ( int i = 0; i < size; i++ )
+ for ( int i = 0, size = c.size(); i < size; i++ )
{
-
- value = c.get( i );
+ Object value = c.get( i );
if ( value != null )
{