You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/17 07:25:46 UTC
[GitHub] [lucene-solr] jpountz opened a new pull request #1882: LUCENE-9529: Track dirtiness of stored fields via a number of docs, not chunks.
jpountz opened a new pull request #1882:
URL: https://github.com/apache/lucene-solr/pull/1882
The problem of tracking dirtiness via numbers of chunks is that larger
chunks make stored fields readers more likely to be considered dirty, so
I'm trying to work around it by tracking numbers of docs instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] rmuir commented on pull request #1882: LUCENE-9529: Track dirtiness of stored fields via a number of docs, not chunks.
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #1882:
URL: https://github.com/apache/lucene-solr/pull/1882#issuecomment-694339576
+1
We can always try to improve this thing later in subsequent issues. This still keeps a hard safety net on the number of dirty chunks, so I can't see it introducing any new worst-case behavior
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jpountz commented on pull request #1882: LUCENE-9529: Track dirtiness of stored fields via a number of docs, not chunks.
Posted by GitBox <gi...@apache.org>.
jpountz commented on pull request #1882:
URL: https://github.com/apache/lucene-solr/pull/1882#issuecomment-694177685
Agreed, I just pushed a change to take care of term vectors as well that I had locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] rmuir commented on pull request #1882: LUCENE-9529: Track dirtiness of stored fields via a number of docs, not chunks.
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #1882:
URL: https://github.com/apache/lucene-solr/pull/1882#issuecomment-694177068
we may want to apply new logic to the CompressingTermVectorsWriter as well for consistency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jpountz merged pull request #1882: LUCENE-9529: Track dirtiness of stored fields via a number of docs, not chunks.
Posted by GitBox <gi...@apache.org>.
jpountz merged pull request #1882:
URL: https://github.com/apache/lucene-solr/pull/1882
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org