[GitHub] [arrow] drin commented on a diff in pull request #14402: ARROW-15540: [C++] Allow the substrait consumer to accept plans with hints and nullable literals

[GitBox <gi...@apache.org>]

drin commented on code in PR #14402:
URL: https://github.com/apache/arrow/pull/14402#discussion_r996015521


##########
cpp/src/arrow/engine/substrait/serde.h:
##########
@@ -261,10 +261,17 @@ Status CheckMessagesEquivalent(std::string_view message_name, const Buffer& l_bu
 ///
 /// \param[in] type_name the name of the Substrait message type to convert
 /// \param[in] json the JSON string to convert
+/// \param[in] ignore_unknown_fields if true then unknown fields will be ignored and
+///            will not cause an error
+///
+///            This should generally be true to allow consumption of plans from newer
+///            producers but setting to false can be useful if you are testing
+///            conformance to a specific Substrait version
 /// \return a buffer filled with the binary protobuf serialization of message
 ARROW_ENGINE_EXPORT
 Result<std::shared_ptr<Buffer>> SubstraitFromJSON(std::string_view type_name,
-                                                  std::string_view json);
+                                                  std::string_view json,
+                                                  bool ignore_unknown_fields = false);

Review Comment:
   Just my guess, but `outdated` might mean that the line numbers no longer match up (surrounding code has changed beyond some threshold). Since this change is within other context, the diff itself is not outdated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org