You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bh...@apache.org on 2016/03/22 17:04:43 UTC

git commit: updated refs/heads/4.5 to 238954c

Repository: cloudstack
Updated Branches:
  refs/heads/4.5 155ea2e7b -> 238954cf5


CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load

For setting the width of each data item for each row of Port Forwarding rules, it was processing all rules.

Basically for each data item, it was searching in all rules, which is un-necessary.
If there are N-Rules, It was processing N-times.

Now, it only processes one time by taking all N-rules at a time.
The previous solution was of O(NxN). Now its changed to O(N).

(cherry picked from commit 48df255f71e9938cc9e0879cbc60d9a0a778d95a)
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/238954cf
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/238954cf
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/238954cf

Branch: refs/heads/4.5
Commit: 238954cf58edce3389a73a837fca3d0796fb612d
Parents: 155ea2e
Author: Nitin Kumar Maharana <ni...@gmail.com>
Authored: Tue Nov 17 23:02:55 2015 +0530
Committer: Rohit Yadav <ro...@shapeblue.com>
Committed: Tue Mar 22 17:04:20 2016 +0100

----------------------------------------------------------------------
 ui/scripts/ui/widgets/multiEdit.js | 3 ---
 1 file changed, 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/238954cf/ui/scripts/ui/widgets/multiEdit.js
----------------------------------------------------------------------
diff --git a/ui/scripts/ui/widgets/multiEdit.js b/ui/scripts/ui/widgets/multiEdit.js
index c4de8ce..e14f3ef 100755
--- a/ui/scripts/ui/widgets/multiEdit.js
+++ b/ui/scripts/ui/widgets/multiEdit.js
@@ -278,9 +278,6 @@
                     $td.addClass('blank');
                 }
 
-                // Align width to main header
-                _medit.refreshItemWidths($multi);
-                
                 if (data._hideFields &&
                     $.inArray(fieldName, data._hideFields) > -1) {
                     $td.addClass('disabled');