You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/27 08:54:20 UTC
[GitHub] [flink] SteNicholas opened a new pull request #12354: [FLINK-17572][runtime] Remove checkpoint alignment buffered metric from webui
SteNicholas opened a new pull request #12354:
URL: https://github.com/apache/flink/pull/12354
## What is the purpose of the change
*After avoid caching buffers for blocked input channels before barrier alignment, runtime never cache buffers while checkpoint barrier alignment, therefore checkpoint alignment buffered metric would always be 0, which should remove it directly in `CheckpointStatistics `, `CheckpointingStatistics`, `TaskCheckpointStatistics`, `TaskCheckpointStatisticsWithSubtaskDetails` and `SubtaskCheckpointStatistics`.*
## Brief change log
- *Remove `alignmentBuffered` attribute in `CheckpointStatistics `, `CheckpointingStatistics`, `TaskCheckpointStatistics`, `TaskCheckpointStatisticsWithSubtaskDetails` and `SubtaskCheckpointStatistics`*
- *Remove `alignment_buffered` in Checkpoint Detail from `job-checkpoints.component.html`.*
- *Remove `alignment_buffered` column in document of `/jobs/:jobid/checkpoints` rest interface.*
## Verifying this change
- *Modify test object create by `CheckpointStatistics `, `CheckpointingStatistics`, `TaskCheckpointStatistics`, `TaskCheckpointStatisticsWithSubtaskDetails` and `SubtaskCheckpointStatistics` in `CheckpointingStatisticsTest`, `TaskCheckpointStatisticsTest` and `TaskCheckpointStatisticsWithSubtaskDetailsTest`.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12354: [FLINK-17572][runtime] Remove checkpoint alignment buffered metric from webui
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12354:
URL: https://github.com/apache/flink/pull/12354#issuecomment-634548622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18d7c8a353f4851e8830bf91986fa95e8119de8a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "18d7c8a353f4851e8830bf91986fa95e8119de8a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18d7c8a353f4851e8830bf91986fa95e8119de8a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12354: [FLINK-17572][runtime] Remove checkpoint alignment buffered metric from webui
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12354:
URL: https://github.com/apache/flink/pull/12354#issuecomment-634525524
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 18d7c8a353f4851e8830bf91986fa95e8119de8a (Wed May 27 08:56:40 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12354: [FLINK-17572][runtime] Remove checkpoint alignment buffered metric from webui
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12354:
URL: https://github.com/apache/flink/pull/12354#issuecomment-634548622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18d7c8a353f4851e8830bf91986fa95e8119de8a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2260",
"triggerID" : "18d7c8a353f4851e8830bf91986fa95e8119de8a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18d7c8a353f4851e8830bf91986fa95e8119de8a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2260)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #12354: [FLINK-17572][runtime] Remove checkpoint alignment buffered metric from webui
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12354:
URL: https://github.com/apache/flink/pull/12354#issuecomment-641319363
This breaks the REST API contracts; see the JIRA for details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol closed pull request #12354: [FLINK-17572][runtime] Remove checkpoint alignment buffered metric from webui
Posted by GitBox <gi...@apache.org>.
zentol closed pull request #12354:
URL: https://github.com/apache/flink/pull/12354
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org