You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/10 14:26:52 UTC

[GitHub] [flink] wuchong opened a new pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work

wuchong opened a new pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work
URL: https://github.com/apache/flink/pull/8678
 
 
   
   ## What is the purpose of the change
   
   In order to support Blink runner (especially Blink batch source/sink and lookup source), we need some new source&sink interfaces and changes about TableSchema.
   
   - `AsyncTableFunction`: used as async lookup function, to support async temporal table join (i.e. dimension table join.).
   - `LookupableTableSource`: The LookupableTableSource interface adds support for the table to be accessed via key column(s) in a lookup fashion in order to support temporal table join.
   BoundedTableSource: used for batch table source, returns a bounded DataStream, not a InputFormat, because we also want to reuse existing streaming source implementation to support bounded source, for example: bounded Kafka source.
   - `BoundedTableSink`: used for batch table sink, emit a bounded DataStream, not a OutputFormat. The reason is the same as above.
   
   ## Brief change log
   
   This contribution contains 4 commits:
   
   1. Introduce `BoundedTableSource` 
      - add `isBounded` interface to `StreamTableSource`
      - `BoundedTableSource` extends `StreamTableSource` and expose `getInputFormat`
      - removes `BatchTableSource` and `StreamTableSource` in blink planner
      - support it in blink and flink planner
   2. Introduce `BoundedTableSink`
     - `BoundedTableSink` extends `StreamTableSink` expose `getInputFormat`
     - removes `BatchTableSink` in blink planner
     - support it in blink and flink planner
   3. Introduce `LookupableTableSource`
     - removes `LookupableTableSource` and `LookupConfig` in blink planner
     - support it only in blink planner
   4. Expose `getTableStats` in `TableSource`
     - support it in blink and flink planner
   
   ## Verifying this change
   
   Add some unit tests and integration tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services