You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2023/02/02 18:57:34 UTC

[GitHub] [ozone] szetszwo opened a new pull request, #4242: HDDS-7764. Potential discrepancy of key creation time may cause premature open key clean up.

szetszwo opened a new pull request, #4242:
URL: https://github.com/apache/ozone/pull/4242

   ## What changes were proposed in this pull request?
   
   When a key is created by OMKeyCreateRequest, its creation time is set by Time.now(), which is local time.
    
   When OpenKeyCleanupService checks for expired open keys (OmMetadataManagerImpl.getExpiredOpenKeys()) it uses Instant.now() as the current time, which is UTC time.
   
   They should use the same time zone.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-7764
   
   ## How was this patch tested?
   
   Updated existing unit tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] jojochuang commented on pull request #4242: HDDS-7764. Potential discrepancy of key creation time may cause premature open key clean up.

Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #4242:
URL: https://github.com/apache/ozone/pull/4242#issuecomment-1419362172

   Thanks all for the review. This is merged now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] jojochuang merged pull request #4242: HDDS-7764. Potential discrepancy of key creation time may cause premature open key clean up.

Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang merged PR #4242:
URL: https://github.com/apache/ozone/pull/4242


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org