You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/05 02:05:54 UTC
[GitHub] [dubbo] zrlw opened a new issue #9208: [3.0] github构建时@DisabledIfEnvironmentVariable注解未生效
zrlw opened a new issue #9208:
URL: https://github.com/apache/dubbo/issues/9208
### Environment
* Dubbo version: 3.0
FileSystemDynamicConfigurationTest测试类上有
```
@DisabledIfEnvironmentVariable(named = "DISABLE_FILE_SYSTEM_TEST", matches = "true")
```
.github/workflows/build-and-test-3.yml (github构建3.0 workflow文件)配置了
```
env:
DISABLE_FILE_SYSTEM_TEST: true
```
但是并没有效果，比如：
```
2021-11-04T14:08:18.7565542Z DISABLE_FILE_SYSTEM_TEST: true
...
2021-11-04T14:09:45.0634914Z [INFO] Running org.apache.dubbo.common.config.configcenter.file.FileSystemDynamicConfigurationTest
2021-11-04T14:09:50.1419515Z [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.076 s - in org.apache.dubbo.common.config.configcenter.file.FileSystemDynamicConfigurationTest
<== @DisabledIfEnvironmentVariable(named = "DISABLE_FILE_SYSTEM_TEST", matches = "true") 并没有生效！
```
更糟的是近期commit在FileSystemDynamicConfigurationTest加了FileUtils.cleanDirectory(rootDirectory)，这个操作在github上执行有时候会导致构建操作挂起直至超时，比如：
https://github.com/apache/dubbo/runs/4103013799?check_suite_focus=true
```
2021-11-04T09:10:01.3748548Z [INFO] Running org.apache.dubbo.common.config.configcenter.file.FileSystemDynamicConfigurationTest
2021-11-04T10:19:17.7997819Z ##[error]The action has timed out.
```
### 建议
把FileSystemDynamicConfigurationTest这个类的注解直接改成@Disabled算了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] zrlw closed issue #9208: [3.0] github构建时@DisabledIfEnvironmentVariable注解未生效
Posted by GitBox <gi...@apache.org>.
zrlw closed issue #9208:
URL: https://github.com/apache/dubbo/issues/9208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org