You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/01 18:15:23 UTC
[GitHub] [kafka] mumrah opened a new pull request, #12374: KAFKA-14039 Fix AlterConfigPolicy usage in KRaft
mumrah opened a new pull request, #12374:
URL: https://github.com/apache/kafka/pull/12374
The existing AlterConfigPolicy behavior in ZK clusters is to only validate configs that have been included into the IncrementalAlterConfigs request. While this could be considered a bug, we should make KRaft have the same behavior as ZK with regards to pluggable interfaces like this.
This patch changes the behavior of ConfigurationControlManager to only pass configs to the AlterConfigPolicy that were included in the request. The full set of configs is still passed through the ConfigurationValidator defined by the controller, but only altered configs are passed down to the AlterConfigPolicy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah commented on pull request #12374: KAFKA-14039 Fix AlterConfigPolicy usage in KRaft
Posted by GitBox <gi...@apache.org>.
mumrah commented on PR #12374:
URL: https://github.com/apache/kafka/pull/12374#issuecomment-1183592500
@hachikuji I added coverage for the new behavior in the test you mentioned. The test will first set a regular broker config, and later verify that it isn't passed to the policy when we're modifying other configs for the broker resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah merged pull request #12374: KAFKA-14039 Fix AlterConfigPolicy usage in KRaft
Posted by GitBox <gi...@apache.org>.
mumrah merged PR #12374:
URL: https://github.com/apache/kafka/pull/12374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #12374: KAFKA-14039 Fix AlterConfigPolicy usage in KRaft
Posted by GitBox <gi...@apache.org>.
hachikuji commented on PR #12374:
URL: https://github.com/apache/kafka/pull/12374#issuecomment-1175407296
@mumrah Thanks for the patch. Are there any integration tests we can add to `AdminClientWithPoliciesIntegrationTest`? It would be nice to verify consistent behavior between kraft and zk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org