You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Neha Narkhede (JIRA)" <ji...@apache.org> on 2014/04/04 22:43:18 UTC
[jira] [Commented] (KAFKA-1337) Rationalize new producer configs
[ https://issues.apache.org/jira/browse/KAFKA-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960401#comment-13960401 ]
Neha Narkhede commented on KAFKA-1337:
--------------------------------------
This looks really good. I have posted minor comments that you can address on checkin. Otherwise, I'm a +1 on this.
> Rationalize new producer configs
> --------------------------------
>
> Key: KAFKA-1337
> URL: https://issues.apache.org/jira/browse/KAFKA-1337
> Project: Kafka
> Issue Type: Sub-task
> Components: producer
> Reporter: Jay Kreps
> Attachments: KAFKA-1337.patch
>
>
> New producer configs have been added somewhat haphazardly. Before we consider the producer final, let's do the following:
> 1. Go back and think about all the config names and make sure they are really what we want.
> 2. Add doc strings for all the configs
> 3. Make the config keys non-public.
> 4. Add a feature to differentiate important from non-important configs.
> 5. Add code to generate the website documentation off the internal config docs.
--
This message was sent by Atlassian JIRA
(v6.2#6252)