You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/07 04:08:37 UTC

[GitHub] [pulsar] jerrypeng commented on a change in pull request #9500: Optimize built-in source/sink startup Part 2

jerrypeng commented on a change in pull request #9500:
URL: https://github.com/apache/pulsar/pull/9500#discussion_r571531891



##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/thread/ThreadRuntime.java
##########
@@ -145,6 +204,12 @@ public void stop() {
             }
             // make sure JavaInstanceRunnable is closed
             this.javaInstanceRunnable.close();
+
+            // once the thread quits, clean up the instance
+            fnCache.unregisterFunctionInstance(
+                    instanceConfig.getFunctionId(),
+                    instanceConfig.getInstanceName());
+            log.info("Unloading JAR files for function {}", instanceConfig);

Review comment:
       sure




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org