You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2024/03/18 05:20:25 UTC
[PR] [SPARK-47436][PYTHON][DOCS] Fix docstring links and type hints in Python Data Source [spark]
HyukjinKwon opened a new pull request, #45557:
URL: https://github.com/apache/spark/pull/45557
### What changes were proposed in this pull request?
This PR proposes to fix several links within the documentation, and incorrect type hints.
### Why are the changes needed?
For better readability in the documentation, and correct type hints.
### Does this PR introduce _any_ user-facing change?
No because Python Data Source has not been released yet.
The fix will correct the links, and use the consistent style of types in its documentation.
### How was this patch tested?
Manually verified via `./dev/linter-python`
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47436][PYTHON][DOCS] Fix docstring links and type hints in Python Data Source [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45557:
URL: https://github.com/apache/spark/pull/45557#issuecomment-2003158942
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47436][PYTHON][DOCS] Fix docstring links and type hints in Python Data Source [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #45557:
URL: https://github.com/apache/spark/pull/45557#issuecomment-2002950759
cc @allisonwang-db and @chaoqin-li1123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47436][PYTHON][DOCS] Fix docstring links and type hints in Python Data Source [spark]
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #45557:
URL: https://github.com/apache/spark/pull/45557#discussion_r1534833854
##########
python/pyspark/sql/datasource.py:
##########
@@ -282,7 +282,7 @@ def partitions(self) -> Sequence[InputPartition]:
)
@abstractmethod
- def read(self, partition: InputPartition) -> Iterator[Union[Tuple, Row]]:
+ def read(self, partition: InputPartition) -> Union[Iterator[Tuple], Iterator[Row]]:
Review Comment:
Good catch. We should not suggest mixing tuple and row return types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47436][PYTHON][DOCS] Fix docstring links and type hints in Python Data Source [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #45557: [SPARK-47436][PYTHON][DOCS] Fix docstring links and type hints in Python Data Source
URL: https://github.com/apache/spark/pull/45557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47436][PYTHON][DOCS] Fix docstring links and type hints in Python Data Source [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #45557:
URL: https://github.com/apache/spark/pull/45557#issuecomment-2003145423
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org