You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/27 23:48:47 UTC
[GitHub] [hbase] bharathv opened a new pull request #1095: HBASE-23257:
Track clusterID in stand by masters (#798)
bharathv opened a new pull request #1095: HBASE-23257: Track clusterID in stand by masters (#798)
URL: https://github.com/apache/hbase/pull/1095
This patch implements a simple cache that all the masters
can lookup to serve cluster ID to clients. Active HMaster
is still responsible for creating it but all the masters
will read it from fs to serve clients.
RPCs exposing it will come in a separate patch as a part of
HBASE-18095.
Signed-off-by: Andrew Purtell <ap...@apache.org>
Signed-off-by: Wellington Chevreuil <wc...@apache.org>
Signed-off-by: Guangxu Cheng <gu...@gmail.com>
(cherry picked from commit c2e01f2398424104a6faae901b12f782ca74c284)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv closed pull request #1095: HBASE-23257: Track
clusterID in stand by masters (#798)
Posted by GitBox <gi...@apache.org>.
bharathv closed pull request #1095: HBASE-23257: Track clusterID in stand by masters (#798)
URL: https://github.com/apache/hbase/pull/1095
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] apurtell commented on a change in pull request #1095:
HBASE-23257: Track clusterID in stand by masters (#798)
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #1095: HBASE-23257: Track clusterID in stand by masters (#798)
URL: https://github.com/apache/hbase/pull/1095#discussion_r372131884
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/CachedClusterId.java
##########
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.master;
+
+import java.io.IOException;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.ClusterId;
+import org.apache.hadoop.hbase.util.FSUtils;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
+import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
+
+/**
+ * Caches the cluster ID of the cluster. For standby masters, this is used to serve the client
+ * RPCs that fetch the cluster ID. ClusterID is only created by an active master if one does not
+ * already exist. Standby masters just read the information from the file system. This class is
+ * thread-safe.
+ *
+ * TODO: Make it a singleton without affecting concurrent junit tests.
+ */
+@InterfaceAudience.Private
+public class CachedClusterId {
+
+ public static final Logger LOG = LoggerFactory.getLogger(CachedClusterId.class);
+ private static final int MAX_FETCH_TIMEOUT_MS = 10000;
+
+ private Path rootDir;
+ private FileSystem fs;
+
+ // When true, indicates that a FileSystem fetch of ClusterID is in progress. This is used to
+ // avoid multiple fetches from FS and let only one thread fetch the information.
+ AtomicBoolean fetchInProgress = new AtomicBoolean(false);
+
+ // When true, it means that the cluster ID has been fetched successfully from fs.
+ private AtomicBoolean isClusterIdSet = new AtomicBoolean(false);
+ // Immutable once set and read multiple times.
+ private ClusterId clusterId;
+
+ // cache stats for testing.
+ private AtomicInteger cacheMisses = new AtomicInteger(0);
Review comment:
Nit: A bit wasteful to have this just for a test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1095: HBASE-23257: Track
clusterID in stand by masters (#798)
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1095: HBASE-23257: Track clusterID in stand by masters (#798)
URL: https://github.com/apache/hbase/pull/1095#issuecomment-579060018
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 32s | branch-2 passed |
| +1 :green_heart: | compile | 0m 54s | branch-2 passed |
| +1 :green_heart: | checkstyle | 1m 11s | branch-2 passed |
| +1 :green_heart: | shadedjars | 4m 18s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | branch-2 passed |
| +0 :ok: | spotbugs | 2m 53s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 2m 52s | branch-2 passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 51s | the patch passed |
| +1 :green_heart: | compile | 0m 55s | the patch passed |
| +1 :green_heart: | javac | 0m 55s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 10s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 4m 15s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 15m 38s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 35s | the patch passed |
| +1 :green_heart: | findbugs | 3m 18s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 151m 41s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. |
| | | 205m 24s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1095/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1095 |
| JIRA Issue | HBASE-23257 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 215f7abb36e8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1095/out/precommit/personality/provided.sh |
| git revision | branch-2 / e0f913323e |
| Default Java | 1.8.0_181 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1095/1/testReport/ |
| Max. process+thread count | 6126 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1095/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on a change in pull request #1095:
HBASE-23257: Track clusterID in stand by masters (#798)
Posted by GitBox <gi...@apache.org>.
bharathv commented on a change in pull request #1095: HBASE-23257: Track clusterID in stand by masters (#798)
URL: https://github.com/apache/hbase/pull/1095#discussion_r372135621
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/CachedClusterId.java
##########
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.master;
+
+import java.io.IOException;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.ClusterId;
+import org.apache.hadoop.hbase.util.FSUtils;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
+import org.apache.hbase.thirdparty.com.google.common.base.Preconditions;
+
+/**
+ * Caches the cluster ID of the cluster. For standby masters, this is used to serve the client
+ * RPCs that fetch the cluster ID. ClusterID is only created by an active master if one does not
+ * already exist. Standby masters just read the information from the file system. This class is
+ * thread-safe.
+ *
+ * TODO: Make it a singleton without affecting concurrent junit tests.
+ */
+@InterfaceAudience.Private
+public class CachedClusterId {
+
+ public static final Logger LOG = LoggerFactory.getLogger(CachedClusterId.class);
+ private static final int MAX_FETCH_TIMEOUT_MS = 10000;
+
+ private Path rootDir;
+ private FileSystem fs;
+
+ // When true, indicates that a FileSystem fetch of ClusterID is in progress. This is used to
+ // avoid multiple fetches from FS and let only one thread fetch the information.
+ AtomicBoolean fetchInProgress = new AtomicBoolean(false);
+
+ // When true, it means that the cluster ID has been fetched successfully from fs.
+ private AtomicBoolean isClusterIdSet = new AtomicBoolean(false);
+ // Immutable once set and read multiple times.
+ private ClusterId clusterId;
+
+ // cache stats for testing.
+ private AtomicInteger cacheMisses = new AtomicInteger(0);
Review comment:
Agree... wish Java had C++ like macros that we could use to inject DEBUG only code :D.
This code also exists in the master, I'll have to cleanup from there. Can I do it as a follow up?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] bharathv commented on issue #1095: HBASE-23257: Track
clusterID in stand by masters (#798)
Posted by GitBox <gi...@apache.org>.
bharathv commented on issue #1095: HBASE-23257: Track clusterID in stand by masters (#798)
URL: https://github.com/apache/hbase/pull/1095#issuecomment-579542077
Will be merged as a part of #1098
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services