[GitHub] [netbeans] lbownik commented on pull request #4080: code and test cleaning

[GitBox <gi...@apache.org>]

lbownik commented on PR #4080:
URL: https://github.com/apache/netbeans/pull/4080#issuecomment-1121513373

   "As far as I can see this is just cosmetic changes to support a new JDK version, without real improvements, right?"
   
   Yes:  The PR does not change the behavior.
   No: 
   1. There are small improvements in readability (I can revert finals's and this'es if you insist). 
   2. There are small performance improvements:
     2.1 I removed needles "ChangeSupport.fireChange(event)" method and merged it's body with the public "fireChange().
     2.2 I relplaced iterators with lambdas in NBCollections.java (lambdas are 2x farster on my machine [Win 10 + Oracle JDK8]), which additionally shaved off 2 lines of code per change (readability).
     2.3 I replaces 2 anonymous classes  with lambdas in NBCollections.java (no need for class lodaer to load these any more). 
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists