[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1328: MINIFICPP-1812 - Clean up Repository threads

[GitBox <gi...@apache.org>]

szaszm commented on code in PR #1328:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1328#discussion_r934641557


##########
libminifi/include/core/ThreadedRepository.h:
##########
@@ -0,0 +1,106 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <memory>
+#include <thread>
+
+#include "Repository.h"
+#include "TraceableResource.h"
+
+namespace org::apache::nifi::minifi::core {
+
+class ThreadedRepository : public core::Repository, public core::TraceableResource {
+ public:
+  using Repository::Repository;
+
+  ~ThreadedRepository() override {
+    if (running_state_.load() != RUNNING_STATE::STOPPED) {
+      logger_->log_error("Thread of %s should have been stopped in subclass before ThreadedRepository's destruction", name_);
+    }
+  }
+
+  bool initialize(const std::shared_ptr<Configure>& /*configure*/) override {
+    return true;
+  }
+
+  // Starts repository monitor thread
+  bool start() override {
+    // if STOPPED, turn to STARTING, otherwise return
+    RUNNING_STATE expected{RUNNING_STATE::STOPPED};

Review Comment:
   I think all caps naming should be reserved for macros. Symbolic constants, including enum values are edge case, so I usually accept either, but they should be CamelCase. The type name should definitely be CamelCase, unless following some standard-like snake_case pattern from somewhere else. Please rename.
   
   ```suggestion
       RunningState expected{RunningState::Stopped};
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org