[GitHub] [ozone] hanishakoneru commented on a change in pull request #3052: HDDS-6235. Empty KeyValueContainers are replicated without chunks directory.

[GitBox <gi...@apache.org>]

hanishakoneru commented on a change in pull request #3052:
URL: https://github.com/apache/ozone/pull/3052#discussion_r814062460



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/TarContainerPacker.java
##########
@@ -209,6 +216,12 @@ public void pack(Container<KeyValueContainerData> container,
   private void includePath(Path dir, String subdir,
       ArchiveOutputStream archiveOutput) throws IOException {
 
+    // Add a directory entry before adding files, in case the directory is
+    // empty.
+    ArchiveEntry entry = archiveOutput.createArchiveEntry(dir.toFile(), subdir);
+    archiveOutput.putArchiveEntry(entry);
+
+    // Add files in the directory.
     try (Stream<Path> dirEntries = Files.list(dir)) {

Review comment:
       @symious the error is thrown because the chunk directory does not exist. Not having chunk files in the directory should not be a problem here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org