You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/07/11 01:30:16 UTC

[GitHub] [trafficserver] maskit commented on a diff in pull request #8949: Do NOT setup internal transfer if ua_entry is nullptr

maskit commented on code in PR #8949:
URL: https://github.com/apache/trafficserver/pull/8949#discussion_r917482842


##########
proxy/http/HttpSM.cc:
##########
@@ -6597,6 +6597,11 @@ HttpSM::setup_error_transfer()
 void
 HttpSM::setup_internal_transfer(HttpSMHandler handler_arg)
 {
+  if (ua_entry == nullptr || ua_entry->vc == nullptr) {

Review Comment:
   Don't we need to call `HTTP_SM_SET_DEFAULT_HANDLER(handler_arg)` even if a client is already gone?
   https://github.com/apache/trafficserver/blob/15bea4dd946c8cb6fc2000a4b31cf4f2f261b29d/proxy/http/HttpSM.cc#L1769-L1771



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org