[GitHub] [incubator-paimon] zhangjun0x01 commented on a diff in pull request #646: [core] add read batch size option

["zhangjun0x01 (via GitHub)" <gi...@apache.org>]

zhangjun0x01 commented on code in PR #646:
URL: https://github.com/apache/incubator-paimon/pull/646#discussion_r1141548782


##########
paimon-format/src/main/java/org/apache/paimon/format/orc/OrcFileFormat.java:
##########
@@ -62,13 +61,15 @@ public class OrcFileFormat extends FileFormat {
     private final Properties orcProperties;
     private final org.apache.hadoop.conf.Configuration readerConf;
     private final org.apache.hadoop.conf.Configuration writerConf;
+    private final int readBatchSize;
 
-    public OrcFileFormat(Options formatOptions) {
+    public OrcFileFormat(Options formatOptions, int readBatchSize) {

Review Comment:
   Yes, we can get `readBatchSize` by `option.get('read. batch-size')`. But I don't think we should do this way. We should use `CoreOptions#READ_BATCH_SIZE.key()`, but the `paimon-format` module does not reference the `paimon-core` module, so I pass this parameter from `paimon-core` to `paimon-format`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org