[GitHub] [helix] xyuanlu commented on a change in pull request #1920: Make theadpool shutdown timeout configurable for the HelixTaskExecutor.

[GitBox <gi...@apache.org>]

xyuanlu commented on a change in pull request #1920:
URL: https://github.com/apache/helix/pull/1920#discussion_r767021180



##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -225,14 +249,12 @@ public void registerMessageHandlerFactory(String type, MessageHandlerFactory fac
         _monitor.createExecutorMonitor(type, newPool);
         return newPool;
       });
-      LOG.info(
-          "Registered message handler factory for type: " + type + ", poolSize: " + threadpoolSize
-              + ", factory: " + factory + ", pool: " + _executorMap.get(type));
+      LOG.info("Registered message handler factory for type: " + type + ", poolSize: " + threadpoolSize + ", factory: "

Review comment:
       nit: I would suggest using [parameterized logging](http://www.slf4j.org/faq.html#logging_performance). String + String adds a lot cost when constructing the message parameter. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org