Re: svn commit: r571175 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp_common.c xdocs/miscellaneous/changelog.xml

[Jim Jagielski <ji...@jaguNET.com>]

On Aug 30, 2007, at 12:46 PM, Rainer Jung wrote:

> Jim Jagielski wrote:
>> On Aug 30, 2007, at 11:45 AM, Mladen Turk wrote:
>>> Rainer Jung wrote:
>>>> +    /* Always do memcmp including the final \0-termination  
>>>> character.
>>>> +     */
>>>>      switch (header[0]) {
>>>>          case 'A':
>>>> -            if (memcmp(p, "CCEPT", 5) == 0) {
>>>> +            if (memcmp(p, "CCEPT", 6) == 0) {
>>>
>>> Right, but like said this should be a
>>> >            if (memcmp(p, "CCEPT\0", 6) == 0) {
>>>
>>> memcmp compares bytes.
>>>
>> "CCEPT" contains 6 bytes. It's len is 5, but it contains
>> 6 bytes.
>
> We finally also agreed on that

I'm glad that the C language spec was agreed upon :)

*duck*


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org