[GitHub] [lucene-solr] jimczi commented on a change in pull request #897: LUCENE-8978: Maximal Of Minimum Scores Based Concurrent Early Termination

[GitBox <gi...@apache.org>]

jimczi commented on a change in pull request #897: LUCENE-8978: Maximal Of Minimum Scores Based Concurrent Early Termination
URL: https://github.com/apache/lucene-solr/pull/897#discussion_r327454467
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
 ##########
 @@ -276,7 +283,20 @@ protected void updateMinCompetitiveScore(Scorable scorer) throws IOException {
           && pqTop.score != Float.NEGATIVE_INFINITY) { // -Infinity is the score of sentinels
       // since we tie-break on doc id and collect in doc id order, we can require
       // the next float
-      scorer.setMinCompetitiveScore(Math.nextUp(pqTop.score));
 
 Review comment:
   I am not sure that this would have any impact but theoretically you don't need to a full pq if the minimum score in the bottom value checker is greater than 0 ? In such case you can just check that the hit threshold is reached and use the minimum score of the other collector to speed up the local scorer ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org