You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2023/05/16 07:21:55 UTC
[GitHub] [kyuubi] turboFei opened a new pull request, #4845: Fix Flaky Test - basic/spnego batch rest client
turboFei opened a new pull request, #4845:
URL: https://github.com/apache/kyuubi/pull/4845
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #4845: [KYUUBI #4807][FOLLOWUP] Fix flaky test "basic batch rest client"
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #4845:
URL: https://github.com/apache/kyuubi/pull/4845#issuecomment-1550566847
> This problem is encountered in the real world, which puzzled me.
>
> Compared to repeating more times for consistent local log results, I suggest checking the batch status first and then fetching the local log. Let's see what happens with this approach in #4846 .
It is slow, because we need wait the batch finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4845: Fix flaky test "basic/spnego batch rest client"
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4845:
URL: https://github.com/apache/kyuubi/pull/4845#issuecomment-1549204730
Please rebase, it was partially fixed by another PR just now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei commented on pull request #4845: [KYUUBI #4807][FOLLOWUP] Fix flaky test "basic batch rest client"
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #4845:
URL: https://github.com/apache/kyuubi/pull/4845#issuecomment-1550604982
thanks, merging to master and 1.7.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4845: [KYUUBI #4807][FOLLOWUP] Fix flaky test "basic batch rest client"
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4845:
URL: https://github.com/apache/kyuubi/pull/4845#issuecomment-1550528148
This problem is encountered in the real world, which puzzled me.
Compared to repeating more times for consistent local log results, I suggest checking the batch status first and then fetching the local log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4845: [KYUUBI #4807][FOLLOWUP] Fix flaky test "basic batch rest client"
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4845:
URL: https://github.com/apache/kyuubi/pull/4845#issuecomment-1550581819
Alright then. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] turboFei closed pull request #4845: [KYUUBI #4807][FOLLOWUP] Fix flaky test "basic batch rest client"
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #4845: [KYUUBI #4807][FOLLOWUP] Fix flaky test "basic batch rest client"
URL: https://github.com/apache/kyuubi/pull/4845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org