You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/10/06 16:55:34 UTC
[GitHub] [ozone] umamaheswararao opened a new pull request #2718: HDDS-5833: EC: Fix TestRootedOzoneFileSystem.testBucketDefaultsShouldBeInheritedToFileForEC failure in branch
umamaheswararao opened a new pull request #2718:
URL: https://github.com/apache/ozone/pull/2718
## What changes were proposed in this pull request?
This test was added in arallel to ECREplicationCOnfig change. Since pr CI's ran independetly they both got green. But one change impacted other without conflicts.
Now fixed the test to adapt the ECReplicationConfig change. Besically ECKeyOutputStream#close has issue with partial chunk size(HDDS-5825). So, keeping the chunk config to match 1024.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5833
## How was this patch tested?
Failed test passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao merged pull request #2718: HDDS-5833: EC: Fix TestRootedOzoneFileSystem.testBucketDefaultsShouldBeInheritedToFileForEC failure in branch
Posted by GitBox <gi...@apache.org>.
umamaheswararao merged pull request #2718:
URL: https://github.com/apache/ozone/pull/2718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on a change in pull request #2718: HDDS-5833: EC: Fix TestRootedOzoneFileSystem.testBucketDefaultsShouldBeInheritedToFileForEC failure in branch
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #2718:
URL: https://github.com/apache/ozone/pull/2718#discussion_r723513484
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java
##########
@@ -1557,7 +1557,7 @@ public void testBucketDefaultsShouldBeInheritedToFileForEC()
builder.setBucketLayout(BucketLayout.LEGACY);
builder.setDefaultReplicationConfig(
new DefaultReplicationConfig(ReplicationType.EC,
- new ECReplicationConfig(3, 2)));
+ new ECReplicationConfig("RS-3-2-1024")));
Review comment:
Just for info, you can also use the new constructor here:
```
public ECReplicationConfig(int data, int parity, EcCodec codec,
int ecChunkSize)
```
However the above is fine with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on a change in pull request #2718: HDDS-5833: EC: Fix TestRootedOzoneFileSystem.testBucketDefaultsShouldBeInheritedToFileForEC failure in branch
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on a change in pull request #2718:
URL: https://github.com/apache/ozone/pull/2718#discussion_r723520146
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java
##########
@@ -1557,7 +1557,7 @@ public void testBucketDefaultsShouldBeInheritedToFileForEC()
builder.setBucketLayout(BucketLayout.LEGACY);
builder.setDefaultReplicationConfig(
new DefaultReplicationConfig(ReplicationType.EC,
- new ECReplicationConfig(3, 2)));
+ new ECReplicationConfig("RS-3-2-1024")));
Review comment:
yeah I saw that ctor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org