You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ZENOTME (via GitHub)" <gi...@apache.org> on 2024/12/13 17:05:30 UTC

[PR] fix: day transform compute [iceberg-rust]

ZENOTME opened a new pull request, #796:
URL: https://github.com/apache/iceberg-rust/pull/796

   https://github.com/apache/iceberg-rust/pull/479 change the result type from int to date. And we should also change the computed result for this, otherwise, it will cause the inconsistent error. E.g. the partition compute return a arrow::Int32Array for day transform, however the partition type will be convert to arrow::DataType::Date32 and we will get the error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: day transform compute [iceberg-rust]

Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on PR #796:
URL: https://github.com/apache/iceberg-rust/pull/796#issuecomment-2541879394

   cc @liurenjie1024 @Fokko @Xuanwo @sdd 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: day transform compute [iceberg-rust]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #796:
URL: https://github.com/apache/iceberg-rust/pull/796#discussion_r1886675209


##########
crates/iceberg/src/transform/temporal.rs:
##########
@@ -1214,36 +1214,36 @@ mod test {
                 PredicateOperator::LessThan,
                 Datum::timestamp_from_str(value)?,
             ),
-            Some("name <= 0"),
+            Some("name <= 1970-01-01"),

Review Comment:
   Looks good 👍 
   
   https://github.com/apache/iceberg/blob/f40ec2096bc078b9fd2b59d6beb32cd77e371ac4/api/src/test/java/org/apache/iceberg/transforms/TestTimestampsProjection.java#L576-L590



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix: day transform compute [iceberg-rust]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #796:
URL: https://github.com/apache/iceberg-rust/pull/796


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org