You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lzap (via GitHub)" <gi...@apache.org> on 2024/04/17 16:49:13 UTC
[PR] chore: re-enable file permissions test on darwin [camel-k]
lzap opened a new pull request, #5380:
URL: https://github.com/apache/camel-k/pull/5380
Greetings,
the `TestPermissionDenied` was disabled on Darwin because it was accessing `/root` which does not exist on Mac. Well, MacOS is not UNIX I guess.
A "good first issue" ticket was created:
https://github.com/apache/camel-k/issues/2563
I wanted to take a stab on this, however, unfortunately it looks like `TestPermissionDenied` was already fixed. It now creates a proper temporary file and drops permissions via `Chomod`. The only thing that was left to be done was to remove the build tags.
And this is exactly what this PR does. Tested on the latest MacOS on Macbook Pro M1, I believe Intel should be the same story.
Have a good one. Cheers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: re-enable file permissions test on darwin [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #5380:
URL: https://github.com/apache/camel-k/pull/5380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore: re-enable file permissions test on darwin [camel-k]
Posted by "tdiesler (via GitHub)" <gi...@apache.org>.
tdiesler commented on PR #5380:
URL: https://github.com/apache/camel-k/pull/5380#issuecomment-2063019673
There is another such test, which now works too
https://github.com/apache/camel-k/blob/main/pkg/cmd/source/util_test.go
Perhaps you'd like to remove those build tags there as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org