[GitHub] [cordova-plugin-splashscreen] fquirin commented on issue #178: Android occur crash by java.lang.NullPointerException

[GitBox <gi...@apache.org>]

fquirin commented on issue #178: Android occur crash by java.lang.NullPointerException
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/178#issuecomment-526819594
 
 
   I'm getting the same error and had the same idea to fix it as in the PR linked above (https://github.com/apache/cordova-plugin-splashscreen/pull/149/files) but with one difference: I think we should remove the second null check to keep these lines:
   ```
   splashDialog.dismiss();
   splashDialog = null;
   splashImageView = null;
   ```
   ... just in case the splashDialog actually exists or not?
   
   Is installing from Git the new standard way now for this plugin?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org