You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/28 16:49:53 UTC

[GitHub] [beam] aaltay commented on a change in pull request #11547: All Python DirectRunners call setup/teardown on DoFns

aaltay commented on a change in pull request #11547:
URL: https://github.com/apache/beam/pull/11547#discussion_r416768530



##########
File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
##########
@@ -874,6 +875,7 @@ def process_element(self, element):
 
   def finish_bundle(self):
     self.runner.finish()
+    self.runner.teardown()

Review comment:
       Yes, it does re-instantiate for each bundle. I remember we had a jira somewhere to re-use dofn instances for more than one bundle, we never implemented that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org